1357638 - "dom.forms.inputmode" is referred with Preferences::GetBool() at every click in <input type="text"> and <textarea> and moving focus to them

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

IMEStateManager::SetIMEState() refers "dom.forms.inputmode" with Preferences::GetBool() when it's called with <input type="text"> (or similar) and <textarea>. It's called at every focus change and click.

So, this might not cause performance issue with any benchmark. But it might waste CPU/battery usage. So, perhaps, it should use Preferences::AddBoolVarCache().

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Ben, could you please take this? Thanks!

Comment 2

[Ben Tian (inactive)]

Take

Comment 3

[Ben Tian (inactive)]

Attachment: Bug 1357638 - Use Preferences::AddBoolVarCache() to accelerate dom.forms.inputmode access in IMEStateManager::SetIMEState(),

Review commit: https://reviewboard.mozilla.org/r/131870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131870/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(p1 makes no sense)

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8859890 [details]
Bug 1357638 - Use Preferences::AddBoolVarCache() to accelerate dom.forms.inputmode access in IMEStateManager::SetIMEState(),

https://reviewboard.mozilla.org/r/131870/#review135140

Comment 6

[Ben Tian (inactive)]

Comment on attachment 8859890 [details]
Bug 1357638 - Use Preferences::AddBoolVarCache() to accelerate dom.forms.inputmode access in IMEStateManager::SetIMEState(),

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131870/diff/1-2/

Comment 7

[Ben Tian (inactive)]

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=968758ed21c7

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0127a117bcb
Use Preferences::AddBoolVarCache() to accelerate dom.forms.inputmode access in IMEStateManager::SetIMEState(), r=masayuki

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0127a117bcb