Closed Bug 1357638 Opened 4 years ago Closed 4 years ago

"dom.forms.inputmode" is referred with Preferences::GetBool() at every click in <input type="text"> and <textarea> and moving focus to them

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: masayuki, Assigned: ben.tian)

Details

(Whiteboard: [qf:p3])

Attachments

(1 file)

IMEStateManager::SetIMEState() refers "dom.forms.inputmode" with Preferences::GetBool() when it's called with <input type="text"> (or similar) and <textarea>. It's called at every focus change and click.

So, this might not cause performance issue with any benchmark. But it might waste CPU/battery usage. So, perhaps, it should use Preferences::AddBoolVarCache().
Hi Ben, could you please take this? Thanks!
Flags: needinfo?(btian)
Priority: -- → P1
Whiteboard: [qf]
Take
Assignee: nobody → btian
Flags: needinfo?(btian)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [qf] → [qf:p1]
(p1 makes no sense)
Whiteboard: [qf:p1] → [qf:p3]
Attachment #8859890 - Flags: review?(masayuki)
Comment on attachment 8859890 [details]
Bug 1357638 - Use Preferences::AddBoolVarCache() to accelerate dom.forms.inputmode access in IMEStateManager::SetIMEState(),

https://reviewboard.mozilla.org/r/131870/#review135140
Attachment #8859890 - Flags: review?(masayuki) → review+
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0127a117bcb
Use Preferences::AddBoolVarCache() to accelerate dom.forms.inputmode access in IMEStateManager::SetIMEState(), r=masayuki
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0127a117bcb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.