Closed Bug 1357690 Opened 2 years ago Closed 2 years ago

[Form Autofill] Polish profile item UI in dropdown menu

Categories

(Toolkit :: Form Manager, enhancement, P3)

52 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ralin, Assigned: ralin)

References

Details

(Whiteboard: [form autofill:M2])

Attachments

(3 files, 1 obsolete file)

Got feedback from Fang and Juwei about current dropdown menu UI. They decided to reduce some spaces around text in order to contain more character in box.

For 1 row layout:
- Reduce the left margin of item box. 16px -> 10px
- Reduce the spacer width between to two columns. 10px -> 7px
- Decrease the font size of primary column. 13px -> 12px

For 2 rows layout:
- Reduce the top/bottom maring of item box. 10px -> 7px
- Reduce the spacer width between primary & secondary row. 7px -> 3px
Attached image 2 lines update.png
Attached image 1 line update.png
Status: NEW → ASSIGNED
Attachment #8859888 - Attachment is obsolete: true
Comment on attachment 8859889 [details]
Bug 1357690 - Increase content density of autofill autocomplte results.

https://reviewboard.mozilla.org/r/131866/#review135146

Thanks.

I'll try to find time to add screenshots to mozscreenshots at some point.

::: commit-message-9a035:1
(Diff revision 3)
> +Bug 1357690 - Polish and update profile item style. r=MattN

Nit: Maybe add the word "autofill" before the word "profile" so it's more clear from reading the commit message what it's about. "Polish and update" could be more clear too. Maybe "Increase content density of autofill autocomplte results." See the thread on mozilla.dev.platform about commit messages.
Attachment #8859889 - Flags: review?(MattN+bmo) → review+
Comment on attachment 8859889 [details]
Bug 1357690 - Increase content density of autofill autocomplte results.

https://reviewboard.mozilla.org/r/131866/#review135146

Thank you

> Nit: Maybe add the word "autofill" before the word "profile" so it's more clear from reading the commit message what it's about. "Polish and update" could be more clear too. Maybe "Increase content density of autofill autocomplte results." See the thread on mozilla.dev.platform about commit messages.

Commit message updated. Thanks for the information, I've just joined the group, and will read the thread :)
Keywords: checkin-needed
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1cf690d4c398
Increase content density of autofill autocomplte results. r=MattN
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1cf690d4c398
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.