1357690 - [Form Autofill] Polish profile item UI in dropdown menu

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P3)

Description

[Ray Lin[:ralin]]

Got feedback from Fang and Juwei about current dropdown menu UI. They decided to reduce some spaces around text in order to contain more character in box.

For 1 row layout:
- Reduce the left margin of item box. 16px -> 10px
- Reduce the spacer width between to two columns. 10px -> 7px
- Decrease the font size of primary column. 13px -> 12px

For 2 rows layout:
- Reduce the top/bottom maring of item box. 10px -> 7px
- Reduce the spacer width between primary & secondary row. 7px -> 3px

Comment 1

[Ray Lin[:ralin]]

Attachment: 2 lines update.png

Comment 2

[Ray Lin[:ralin]]

Attachment: 1 line update.png

Comment 3

[Ray Lin[:ralin]]

Attachment: add mock data to result

Review commit: https://reviewboard.mozilla.org/r/131864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131864/

Comment 4

[Ray Lin[:ralin]]

Attachment: Bug 1357690 - Increase content density of autofill autocomplte results.

Review commit: https://reviewboard.mozilla.org/r/131866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131866/

Comment 5

[Ray Lin[:ralin]]

Comment on attachment 8859889 [details]
Bug 1357690 - Increase content density of autofill autocomplte results.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131866/diff/1-2/

Comment 6

[Ray Lin[:ralin]]

Comment on attachment 8859889 [details]
Bug 1357690 - Increase content density of autofill autocomplte results.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131866/diff/2-3/

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8859889 [details]
Bug 1357690 - Increase content density of autofill autocomplte results.

https://reviewboard.mozilla.org/r/131866/#review135146

Thanks.

I'll try to find time to add screenshots to mozscreenshots at some point.

::: commit-message-9a035:1
(Diff revision 3)
> +Bug 1357690 - Polish and update profile item style. r=MattN

Nit: Maybe add the word "autofill" before the word "profile" so it's more clear from reading the commit message what it's about. "Polish and update" could be more clear too. Maybe "Increase content density of autofill autocomplte results." See the thread on mozilla.dev.platform about commit messages.

Comment 8

[Ray Lin[:ralin]]

Comment on attachment 8859889 [details]
Bug 1357690 - Increase content density of autofill autocomplte results.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131866/diff/3-4/

Comment 9

[Ray Lin[:ralin]]

Comment on attachment 8859889 [details]
Bug 1357690 - Increase content density of autofill autocomplte results.

https://reviewboard.mozilla.org/r/131866/#review135146

Thank you

> Nit: Maybe add the word "autofill" before the word "profile" so it's more clear from reading the commit message what it's about. "Polish and update" could be more clear too. Maybe "Increase content density of autofill autocomplte results." See the thread on mozilla.dev.platform about commit messages.

Commit message updated. Thanks for the information, I've just joined the group, and will read the thread :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cf690d4c398
Increase content density of autofill autocomplte results. r=MattN

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cf690d4c398