Closed Bug 1357711 Opened 3 years ago Closed 3 years ago

JSObject::makeLazyGroup should not delazify functions

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
I was just looking at a Gmail profile and I noticed we were spending quite a lot of time delazifying (full parsing) functions under JSObject::makeLazyGroup. I don't think that's necessary (anymore) and the test suite agrees.

I added some logging and we delazified more than 5000 functions there when loading Gmail.
Attachment #8859544 - Flags: review?(bhackett1024)
Attachment #8859544 - Flags: review?(bhackett1024) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/336b737be49a
Remove unnecessary function delazification in JSObject::makeLazyGroup. r=bhackett
Blocks: QF-Websites
https://hg.mozilla.org/mozilla-central/rev/336b737be49a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.