JSObject::makeLazyGroup should not delazify functions

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Created attachment 8859544 [details] [diff] [review]
Patch

I was just looking at a Gmail profile and I noticed we were spending quite a lot of time delazifying (full parsing) functions under JSObject::makeLazyGroup. I don't think that's necessary (anymore) and the test suite agrees.

I added some logging and we delazified more than 5000 functions there when loading Gmail.
Attachment #8859544 - Flags: review?(bhackett1024)
Attachment #8859544 - Flags: review?(bhackett1024) → review+

Comment 1

6 months ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/336b737be49a
Remove unnecessary function delazification in JSObject::makeLazyGroup. r=bhackett
(Assignee)

Updated

6 months ago
Blocks: 1336173

Comment 2

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/336b737be49a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.