Closed
Bug 1357780
Opened 7 years ago
Closed 7 years ago
Custom Tab: Different color for Share option from menu
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: sflorean, Assigned: walkingice)
References
Details
Attachments
(3 files, 3 obsolete files)
Environment: Device: Huawei Honor (Android 5.1.1); Build: Nightly 55.0a1 (2017-04-18); Steps to reproduce: 1. Launch CustomTab Activity; 2. Long tap on any link from the page or image; 3. Observe the share option. Expected result: The options have the same color. Actual result: The color for menu-options are not the same.
Assignee | ||
Comment 2•7 years ago
|
||
One of the key points to reproduce this bug is about the toolbar background color, which effects CustomTab to use different theme.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → walkingice0204
Assignee | ||
Updated•7 years ago
|
Attachment #8868877 -
Attachment is obsolete: true
Attachment #8868877 -
Flags: review?(s.kaspari)
Assignee | ||
Updated•7 years ago
|
Attachment #8868878 -
Attachment is obsolete: true
Attachment #8868878 -
Flags: review?(s.kaspari)
Assignee | ||
Updated•7 years ago
|
Attachment #8868879 -
Attachment is obsolete: true
Attachment #8868879 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 6•7 years ago
|
||
Canceled previous patch. I decided just use one Theme(Theme.AppCompat.Light.NoActionBar) in CustomTabs which cause less visual problems. Since CustomTabs re-uses some widgets from Gecko, and there is no dark theme in Gecko. If I apply dark theme in CustomTabs, I might(already) bite myself.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8869530 [details] Bug 1357780 - CustomTabs get rid of dark theme https://reviewboard.mozilla.org/r/141122/#review144882
Attachment #8869530 -
Flags: review?(s.kaspari) → review+
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8869531 [details] Bug 1357780 - Fix tint problem in Android 4.4 https://reviewboard.mozilla.org/r/141124/#review144884
Attachment #8869531 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 15•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7823d414f9d7 CustomTabs get rid of dark theme r=sebastian https://hg.mozilla.org/integration/autoland/rev/d5db05712359 Fix tint problem in Android 4.4 r=sebastian
Keywords: checkin-needed
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7823d414f9d7 https://hg.mozilla.org/mozilla-central/rev/d5db05712359
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•