If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Show task.extra in task inspector

RESOLVED FIXED

Status

Taskcluster
Tools
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: dustin, Assigned: swapneshks, Mentored)

Tracking

({good-first-bug})

Details

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
The "task details" view of the task inspector omits task.extra.  It should be displayed as JSON just like the task payload.
(Reporter)

Updated

5 months ago
Mentor: dustin@mozilla.com
Keywords: good-first-bug
(Reporter)

Updated

5 months ago
Assignee: dustin → nobody
(Assignee)

Comment 1

5 months ago
Hi.. I'd like to work on this bug.
I'm a beginner and still catching up to things. (Have worked on only 2-3 moz bugs till now)
Flags: needinfo?(dustin)
(Reporter)

Comment 2

5 months ago
Hi!  This is a frontend fix, in a React application.  The source code is at https://github.com/taskcluster/taskcluster-tools

You can see the issue here:
  https://tools.taskcluster.net/task-inspector/#FLLNwbUVT1eoiRUaAJNobw/

The raw task definition being displayed is
  https://queue.taskcluster.net/v1/task/FLLNwbUVT1eoiRUaAJNobw
and you can see it has an "extra" property with a bunch of data in it.  However, that doesn't appear in the UI at the first link.

You should be able to duplicate the error using your local install (with the same taskId), and then get started fixing it :)
Flags: needinfo?(dustin)
(Assignee)

Comment 3

5 months ago
Created attachment 8862068 [details] [diff] [review]
Fix for displaying task.extra in "Task Details" view

In this patch I am assuming that the contents of task.extra have to be parsed as JSON. 
Do let me know if this patch is appropriate.
Attachment #8862068 - Flags: review?(dustin)
(Reporter)

Updated

5 months ago
Assignee: nobody → swapneshks
(Reporter)

Comment 4

5 months ago
Comment on attachment 8862068 [details] [diff] [review]
Fix for displaying task.extra in "Task Details" view

Review of attachment 8862068 [details] [diff] [review]:
-----------------------------------------------------------------

That looks good!  Can you submit a Github pull request so we can get the automated tests run?
Attachment #8862068 - Flags: review?(dustin) → review+
(Assignee)

Comment 5

5 months ago
Pull request created at:

https://github.com/taskcluster/taskcluster-tools/pull/209
(Assignee)

Comment 6

5 months ago
Hi Dustin

Could you provide me with a task definition that does not have task.extra so that I can test it and apply the corresponding fix as discussed in the pull request?
Flags: needinfo?(dustin)
(Reporter)

Comment 7

5 months ago
https://tools.taskcluster.net/task-inspector/#VnfsiYQWTt-qC6TMzu6nXg/
Flags: needinfo?(dustin)
(Assignee)

Comment 8

5 months ago
The pull request has been updated with the requested changes (for the case when task.extra does not exist).

Comment 9

5 months ago
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/eca8f9c7aba1f23405c3415bad101bcbbe493eb7
Bug 1357802 - Show task.extra in task inspector (#209)

* Bug 1357802 - Show task.extra in task inspector

Add fix for displaying "Extra" from task.extra in "Task Details" view

* Bug 1357802 - Add condition for no task.extra

Add condition to skip task.extra rendering when it is non-existent

* Bug 1357802 - Treat task.extra as an object

task.extra will be a plain object when not specified

Comment 10

5 months ago
Landed in master via https://github.com/taskcluster/taskcluster-tools/commit/eca8f9c7aba1f23405c3415bad101bcbbe493eb7
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.