Closed
Bug 1357889
Opened 7 years ago
Closed 7 years ago
forbid LLVM >= 4.0 for being used for stylo bindgen (require llvm39)
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
(Whiteboard: [stylo])
Attachments
(1 file)
|
2.48 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
Released versions of LLVM 4.0 do not work properly with bindgen, and the in-development 5.0 version doesn't either. To avoid undue hair-pulling, we should detect such versions early during configure and advise the user about appropriate versions.
|
Assignee | |
Comment 1•7 years ago
|
||
A small quality-of-life improvement for people getting started with Stylo.
Attachment #8859737 -
Flags: review?(giles)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8859737 [details] [diff] [review] forbid LLVM >= 4.0 for being used for stylo bindgen Review of attachment 8859737 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8859737 -
Flags: review?(giles) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/346c7bcd0ef9 forbid LLVM >= 4.0 for being used for stylo bindgen; r=rillian
|
||
Updated•7 years ago
|
Blocks: stylo-nightly-build, stylo-tooling
Summary: forbid LLVM >= 4.0 for being used for stylo bindgen → forbid LLVM >= 4.0 for being used for stylo bindgen (require llvm39)
Whiteboard: [stylo]
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/346c7bcd0ef9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•