1357898 - Remove the urlclassifier.max-complete-age pref

Status: RESOLVED DUPLICATE of bug 1333328

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[François Marier [:francois]]

The urlclassifier.max-complete-age pref allows users to configure the amount of time that entries are considered fresh in the Safe Browsing cache (V2 only).

This doesn't make sense as a user-controllable toggle since it's a hard requirement of the Safe Browsing protocol. It should be a constant instead.

Comment 1

[Thomas Nguyen (:tnguyen)]

The pref occurs in some tests to make sure staleness of cache tables work correctly (we probably not want to wait 45 mins to make sure that the tables will be stale).
If we would like to remove the preference, I think we have to add new gtest for v2 stale functionality

Comment 2

[Thomas Nguyen (:tnguyen)]

I would like to re-set dependency to 1333328, I see in the patch Dimi did remove using of gFreshnessGuarantee

Comment 3

[Dimi Lee [:dimi]]

The reason I am removing it is because we are going to use 15 mins as negative and positive cache duration for V2,
so freshnessGuarantee is no more needed.

Comment 4

[François Marier [:francois]]

(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #1)
> The pref occurs in some tests to make sure staleness of cache tables work
> correctly (we probably not want to wait 45 mins to make sure that the tables
> will be stale).
> If we would like to remove the preference, I think we have to add new gtest
> for v2 stale functionality

Good catch Thomas!

(In reply to Thomas Nguyen[:tnguyen] ni plz from comment #2)
> I would like to re-set dependency to 1333328, I see in the patch Dimi did
> remove using of gFreshnessGuarantee

Thanks for updating the dependencies.

We can close this as a duplicate once Dimi's refactoring lands.

Comment 5

[François Marier [:francois]]

Assigning to Dimi since he will close this at the same time as the V2 refactoring.