1357964 - Fix network-details-panel-toggle direction in vertical mode

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[magicp]

Attachment: network-details-panel-toggle.png

[Steps to reproduce]
1. Start Nightly
2. Open net monitor (docking to side and vertical mode)
3. Go to any sites
4. Confirm direction of network-details-panel-toggle

[Actual Results]
network-details-panel-toggle direction is left or right.

[Expected Results]
network-details-panel-toggle direction is up or down in vertical mode.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

Honza

Comment 2

[Michael Hoffmann]

Attachment: bug1357964.patch

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8865014 [details] [diff] [review]
bug1357964.patch

Review of attachment 8865014 [details] [diff] [review]:
-----------------------------------------------------------------

Works great for me, thanks for the patch!

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03f93e71d647
Rotate network-details-panel-toggle button in vertical mode. r=honza

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03f93e71d647

Comment 6

[Md.Tarikul Islam Oashi]

I have reproduced this bug with nightly 55.0a1 (2017-04-19) on "Linux Mint 18.1 Serena"(64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1.

Build ID 	20170614100332
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[Bugday-20170614]

Comment 7

[Sajedul Islam]

I have reproduced this bug with Nightly 55.0a1 (2017-04-19) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly 56.0a1 !

Build   ID    20170614030206
User Agent    Mozilla/5.0 (Windows NT 10.0; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 8

[Md.Tarikul Islam Oashi]

As per Comment 6 & Comment 7, I am marking this bug as verified fixed

Comment 9

[Julien Cristau [:jcristau]]

Is this a regression in the new net monitor?  Do we want to fix this in 55?

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8865014 [details] [diff] [review]
bug1357964.patch

Approval Request Comment
[Feature/Bug causing the regression]: not specified
[User impact if declined]: wrong icon for a button
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes, see comment #0
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: just CSS change
[String changes made/needed]: n/a

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8865014 [details] [diff] [review]
bug1357964.patch

css fix for netmonitor, beta55+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/00c04e6496ed

Comment 13

[Fahima Zulfath]

The issue is no longer reproducible on Firefox 55.0b4.
Build ID: 20170622104007
Tests were performed under Windows 10x64.
[Firefox 55 Beta 4 Testday - 20170623]