Closed
Bug 1357993
Opened 8 years ago
Closed 8 years ago
Permaorange in dom/base/test/test_domwindowutils.html when Gecko 55 merges to beta on 2017-06-12
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox-esr45 | --- | unaffected |
| firefox-esr52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | + | fixed |
People
(Reporter: philor, Assigned: daisuke)
References
Details
Attachments
(1 file)
If you're going to do anything with animations, you have to set the pref, to not break on beta and release.
https://treeherder.mozilla.org/logviewer.html#?job_id=92882764&repo=try (should be able to repro locally by just changing /config/milestone.txt from 55a1 to 55).
[Tracking Requested - why for this release]:
Merge bustage, closed tree, delayed b1, anguish.
|
Reporter | |
Updated•8 years ago
|
Flags: needinfo?(dakatsuka)
|
||
Comment 3•8 years ago
|
||
(In reply to Daisuke Akatsuka (:daisuke) from comment #2)
> Thanks, Phil.
> I fix this one.
Thanks Daisuke!
Assignee: nobody → dakatsuka
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8860823 [details]
Bug 1357993: Set dom.animations-api.core.enabled preference.
https://reviewboard.mozilla.org/r/132814/#review135630
It's hard to review this kind of changes between files on MozReview...
::: dom/base/test/file_domwindowutils_animation.html:6
(Diff revision 1)
> +<!DOCTYPE html>
> +<html>
> +<head>
> + <meta charset="UTF-8">
> + <title>DOMWindowUtils test with animation</title>
> + <style></style>
Do we really need this <style>?
::: dom/base/test/file_domwindowutils_animation.html:140
(Diff revision 1)
> +}
> +
> +window.addEventListener("load", test_getUnanimatedComputedStyle);
> +
> +</script>
> +</pre>
I don't see any <pre>.
Attachment #8860823 -
Flags: review?(hikezoe) → review+
|
Assignee | |
Comment 6•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8860823 [details]
Bug 1357993: Set dom.animations-api.core.enabled preference.
https://reviewboard.mozilla.org/r/132814/#review135630
> Do we really need this <style>?
Thank you for your quick response, Hiro!
I wrote to add style like:
document.styleSheets[0].insertRule(cssAnimationStyle, 0); ( line 48 )
Or, is it might better to make a new <style> using createElement?
|
|
||
Comment 7•8 years ago
|
||
(In reply to Daisuke Akatsuka (:daisuke) from comment #6)
> Comment on attachment 8860823 [details]
> Bug 1357993: Set dom.animations-api.core.enabled preference.
>
> https://reviewboard.mozilla.org/r/132814/#review135630
>
> > Do we really need this <style>?
>
> Thank you for your quick response, Hiro!
>
> I wrote to add style like:
>
> document.styleSheets[0].insertRule(cssAnimationStyle, 0); ( line 48 )
>
> Or, is it might better to make a new <style> using createElement?
I think so, just like we do in addStyle() in dom/animation/test/testcommon.js.
|
|
||
Comment 8•8 years ago
|
||
But of course, it's up to you.
|
|
Assignee | |
Comment 9•8 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #8)
> But of course, it's up to you.
I'll modify as same to addStyle().
Thanks!
| Comment hidden (mozreview-request) |
|
||
Comment 11•8 years ago
|
||
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0c2cde6611a
Set dom.animations-api.core.enabled preference. r=hiro
|
||
Comment 12•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•