Closed
Bug 1357997
Opened 8 years ago
Closed 7 years ago
Replace url.openConnection with ProxySelector.openConnectionWithProxy
Categories
(Firefox for Android Graveyard :: General, enhancement, P1)
Firefox for Android Graveyard
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jhao, Assigned: jhao)
References
Details
(Whiteboard: [tor-mobile])
Attachments
(1 file)
We need to make sure all http connections in Fennec goes through a centralized proxy. The connections don't have to go through Necko as argued in bug 507641. We could do it like this commit: https://github.com/guardianproject/tor-browser/commit/4b68807942c7bce90760ea1f9450f6b4ab9e8db9
Updated•8 years ago
|
Assignee: nobody → jhao
Priority: -- → P1
Updated•8 years ago
|
Whiteboard: [tor-mobile]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8861283 -
Flags: review?(rnewman)
Comment 5•8 years ago
|
||
Comment on attachment 8861283 [details] Bug 1357997 - Use ProxySelector.openConnection instead of url.openConnection. This looks fine to me, but Sebastian has more recent context than me. I'm also confused by omg.util.ProxySelector, even though I reviewed the patch that added `openConnectionWithProxy`! `openConnectionWithProxy` uses `java.net.ProxySelector`, not `omg.util.ProxySelector`. Callers through `GeckoAppShell` that use `ProxySelector().select` -- Gecko callers trying to use `getProxyForURI` -- will use our code. Java callers that use `omg.util.ProxySelector.openConnectionWithProxy` will use the system `ProxySelector`! I expect the intent is that these two classes behave identically, reading system properties, but I don't see how we could guarantee that. Sebastian, what are your thoughts?
Attachment #8861283 -
Flags: review?(rnewman) → review?(s.kaspari)
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8861283 [details] Bug 1357997 - Use ProxySelector.openConnection instead of url.openConnection. https://reviewboard.mozilla.org/r/133234/#review138390 Sorry, this took so long. The code changes look good to me. Our helper openConnectionWithProxy() indeed only cares about the system proxy and doesn't use whatever is setup in Gecko (There's no UI for that, but I guess add-ons could set one). Let's file a follow-up bug if we want to add support for this. Also note that we still have some code that does not use HttpUrlConnection (yet?). So even after this lands we do not proxy *all* connections yet.
Attachment #8861283 -
Flags: review?(s.kaspari)
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8861283 [details] Bug 1357997 - Use ProxySelector.openConnection instead of url.openConnection. https://reviewboard.mozilla.org/r/133234/#review138396
Attachment #8861283 -
Flags: review+
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #6) > Comment on attachment 8861283 [details] > Bug 1357997 - Use ProxySelector.openConnection instead of url.openConnection. > > https://reviewboard.mozilla.org/r/133234/#review138390 > > Sorry, this took so long. The code changes look good to me. > > Our helper openConnectionWithProxy() indeed only cares about the system > proxy and doesn't use whatever is setup in Gecko (There's no UI for that, > but I guess add-ons could set one). Let's file a follow-up bug if we want to > add support for this. > > Also note that we still have some code that does not use HttpUrlConnection > (yet?). So even after this lands we do not proxy *all* connections yet. Thanks, Sebastian. So what connections do we have beside HttpUrlConnection?
Flags: needinfo?(s.kaspari)
Comment 9•7 years ago
|
||
Some of our code (at least Sync) is using ch.boye.httpclientandroidlib (HttpClient).
Flags: needinfo?(s.kaspari)
Assignee | ||
Updated•7 years ago
|
Summary: Proxy all http connections in Fennec code → Replace url.openConnection with ProxySelector.openConnectionWithProxy
Comment 10•7 years ago
|
||
Pushed by jhao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/676720d93349 Use ProxySelector.openConnection instead of url.openConnection. r=sebastian
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/676720d93349
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•