Closed Bug 1358013 Opened 4 years ago Closed 4 years ago
Implement status-bar tooltips
Net panel's status bar consists of one button and several sections with summary data. All these parts should have an explanatory tooltip. Text for tooltips: Perf button: "Start performance analysis" Number of requests: "Number of requests" Size: "size/transferred size of all requests" Finish: "Total time needed to load all requests" DOMContentLoaded: "Time when 'DOMContentLoad' event occurred" load: "Time when 'load' event occurred" Honza
4 years ago
Priority: -- → P3
@Vangelis: interested in this one? Honza
@Honza will be AFK for a bit, happy to work on it from next week, if that's ok with its schedule!
(In reply to Vangelis Katsikaros from comment #2) > @Honza will be AFK for a bit, happy to work on it from next week, if that's > ok with its schedule! Sure, next week is fine, thanks! Honza
Assignee: nobody → vkatsikaros
Status: NEW → ASSIGNED
Comment on attachment 8861764 [details] Bug 1358013 - Implement status-bar tooltips. https://reviewboard.mozilla.org/r/133770/#review136716 Great, thanks for the patch! Honza
Attachment #8861764 - Flags: review?(odvarko) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/44800134e7db Implement status-bar tooltips. r=Honza
Backed out for failing browser-chrome's browser_misused_characters_in_strings.js: https://hg.mozilla.org/integration/autoland/rev/f8ce7739001e5b25a61e09c68f7121f88fdec92d Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=44800134e7db40eab58a3573ef50387f09d129f4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=94470200&repo=autoland Please use double-quotes (or add the strings to the whitelist in case you have to).
Oh, I am terribly sorry for the back and forth, should have triggered a try! Just making sure I do the proper steps: * I reopened the review as `hg push review` told me to >abort: Review request is submitted or discarded. >You must reopen the review request before it can be updated. >Review requests should only be reopened if your changes have not landed or have >been backed out - file new bugs for follow-up work. * and re pushed the branch * triggered a try
Thanks. The Try push didn't run the failing test (because it's a browser chrome 'bc' test, not a devtools 'dt' one). But from the interdiff between revision 1 and 2, you don't need to run it in my humble opinion. If you prefer, you can still add the test jobs to the push by opening the menu on the top right of the push, clicking 'Add new jobs' and selecting e.g. all bc jobs in the M group for OS X 10.10 opt.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/553ad9bebfa7 Implement status-bar tooltips. r=Honza
backed out in https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7706b9edd277518759814bdec10598db5abc09fa seems one of this 2 bugs caused https://treeherder.mozilla.org/logviewer.html#?job_id=94838707&repo=autoland
Backout by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f9673e8aff0e Backed out changeset 553ad9bebfa7
Sorry, my fault. The strings have to use the English quotation marks: https://en.wikipedia.org/wiki/Quotation_marks_in_English See https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/static/browser_misused_characters_in_strings.js?q=path%3Abrowser_misused_characters_in_strings.js&redirect_type=single#147
Thanks Sebastian, I pushed a patch containing English quotation marks.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/47f3cd662ef1 Implement status-bar tooltips. r=Honza
I have reproduced this bug with Nightly 55.0a1 (2017-04-19) on Windows 8.1 , 64 Bit ! This bug's fix is Verified with latest Nightly ! Build ID 20170501030204 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0 [testday-20170428]
You need to log in before you can comment on or make changes to this bug.