Closed Bug 1358013 Opened 4 years ago Closed 4 years ago

Implement status-bar tooltips

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Honza, Assigned: vkatsikaros, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Net panel's status bar consists of one button and several sections with summary data. All these parts should have an explanatory tooltip.

Text for tooltips:

Perf button: "Start performance analysis"
Number of requests: "Number of requests"
Size: "size/transferred size of all requests" 
Finish: "Total time needed to load all requests"
DOMContentLoaded: "Time when 'DOMContentLoad' event occurred"
load: "Time when 'load' event occurred"

Honza
Mentor: odvarko
Keywords: good-first-bug
Priority: -- → P3
@Vangelis: interested in this one?

Honza
Flags: needinfo?(vkatsikaros)
@Honza will be AFK for a bit, happy to work on it from next week, if that's ok with its schedule!
Flags: needinfo?(vkatsikaros)
(In reply to Vangelis Katsikaros from comment #2)
> @Honza will be AFK for a bit, happy to work on it from next week, if that's
> ok with its schedule!

Sure, next week is fine, thanks!

Honza
Assignee: nobody → vkatsikaros
Status: NEW → ASSIGNED
Comment on attachment 8861764 [details]
Bug 1358013 - Implement status-bar tooltips.

https://reviewboard.mozilla.org/r/133770/#review136716

Great, thanks for the patch!

Honza
Attachment #8861764 - Flags: review?(odvarko) → review+
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44800134e7db
Implement status-bar tooltips. r=Honza
Oh, I am terribly sorry for the back and forth, should have triggered a try!

Just making sure I do the proper steps:
* I reopened the review as `hg push review` told me to
>abort: Review request is submitted or discarded.
>You must reopen the review request before it can be updated.
>Review requests should only be reopened if your changes have not landed or have
>been backed out - file new bugs for follow-up work.
* and re pushed the branch
* triggered a try
Flags: needinfo?(vkatsikaros)
Thanks. The Try push didn't run the failing test (because it's a browser chrome 'bc' test, not a devtools 'dt' one). But from the interdiff between revision 1 and 2, you don't need to run it in my humble opinion. If you prefer, you can still add the test jobs to the push by opening the menu on the top right of the push, clicking 'Add new jobs' and selecting e.g. all bc jobs in the M group for OS X 10.10 opt.
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/553ad9bebfa7
Implement status-bar tooltips. r=Honza
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9673e8aff0e
Backed out changeset 553ad9bebfa7
Thanks Sebastian, I pushed a patch containing English quotation marks.
Flags: needinfo?(vkatsikaros)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/47f3cd662ef1
Implement status-bar tooltips. r=Honza
https://hg.mozilla.org/mozilla-central/rev/47f3cd662ef1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this bug with Nightly 55.0a1 (2017-04-19) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20170501030204
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170428]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.