1358013 - Implement status-bar tooltips

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Net panel's status bar consists of one button and several sections with summary data. All these parts should have an explanatory tooltip.

Text for tooltips:

Perf button: "Start performance analysis"
Number of requests: "Number of requests"
Size: "size/transferred size of all requests" 
Finish: "Total time needed to load all requests"
DOMContentLoaded: "Time when 'DOMContentLoad' event occurred"
load: "Time when 'load' event occurred"

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Vangelis: interested in this one?

Honza

Comment 2

[Vangelis Katsikaros]

@Honza will be AFK for a bit, happy to work on it from next week, if that's ok with its schedule!

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Vangelis Katsikaros from comment #2)
> @Honza will be AFK for a bit, happy to work on it from next week, if that's
> ok with its schedule!

Sure, next week is fine, thanks!

Honza

Comment 4

[Vangelis Katsikaros]

Attachment: Bug 1358013 - Implement status-bar tooltips.

Review commit: https://reviewboard.mozilla.org/r/133770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133770/

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8861764 [details]
Bug 1358013 - Implement status-bar tooltips.

https://reviewboard.mozilla.org/r/133770/#review136716

Great, thanks for the patch!

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44800134e7db
Implement status-bar tooltips. r=Honza

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing browser-chrome's browser_misused_characters_in_strings.js:

https://hg.mozilla.org/integration/autoland/rev/f8ce7739001e5b25a61e09c68f7121f88fdec92d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=44800134e7db40eab58a3573ef50387f09d129f4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=94470200&repo=autoland

Please use double-quotes (or add the strings to the whitelist in case you have to).

Comment 8

[Vangelis Katsikaros]

Comment on attachment 8861764 [details]
Bug 1358013 - Implement status-bar tooltips.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133770/diff/1-2/

Comment 9

[Vangelis Katsikaros]

Oh, I am terribly sorry for the back and forth, should have triggered a try!

Just making sure I do the proper steps:
* I reopened the review as `hg push review` told me to
>abort: Review request is submitted or discarded.
>You must reopen the review request before it can be updated.
>Review requests should only be reopened if your changes have not landed or have
>been backed out - file new bugs for follow-up work.
* and re pushed the branch
* triggered a try

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thanks. The Try push didn't run the failing test (because it's a browser chrome 'bc' test, not a devtools 'dt' one). But from the interdiff between revision 1 and 2, you don't need to run it in my humble opinion. If you prefer, you can still add the test jobs to the push by opening the menu on the top right of the push, clicking 'Add new jobs' and selecting e.g. all bc jobs in the M group for OS X 10.10 opt.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/553ad9bebfa7
Implement status-bar tooltips. r=Honza

Comment 12

[Carsten Book [:Tomcat]]

backed out in https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7706b9edd277518759814bdec10598db5abc09fa

seems one of this 2 bugs caused https://treeherder.mozilla.org/logviewer.html#?job_id=94838707&repo=autoland

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9673e8aff0e
Backed out changeset 553ad9bebfa7

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry, my fault. The strings have to use the English quotation marks: https://en.wikipedia.org/wiki/Quotation_marks_in_English

See https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/static/browser_misused_characters_in_strings.js?q=path%3Abrowser_misused_characters_in_strings.js&redirect_type=single#147

Comment 15

[Vangelis Katsikaros]

Comment on attachment 8861764 [details]
Bug 1358013 - Implement status-bar tooltips.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133770/diff/2-3/

Comment 16

[Vangelis Katsikaros]

Thanks Sebastian, I pushed a patch containing English quotation marks.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47f3cd662ef1
Implement status-bar tooltips. r=Honza

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47f3cd662ef1

Comment 19

[Sajedul Islam]

I have reproduced this bug with Nightly 55.0a1 (2017-04-19) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20170501030204
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170428]