Make the second arg of insertRule optional

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM: CSS Object Model
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

See https://www.w3.org/Bugs/Public/show_bug.cgi?id=27384

This applies to CSSStyleSheet and CSSGroupingRule.

https://github.com/w3c/web-platform-tests/issues/5524 tracks adding tests for this.
Created attachment 8859879 [details] [diff] [review]
Make the second arg of CSSOM insertRule methods optional

This tracks the spec change in https://www.w3.org/Bugs/Public/show_bug.cgi?id=27384
Attachment #8859879 - Flags: review?(cam)
Comment on attachment 8859879 [details] [diff] [review]
Make the second arg of CSSOM insertRule methods optional

Review of attachment 8859879 [details] [diff] [review]:
-----------------------------------------------------------------

Was going to ask if we need a test before the WPT ones arrive, but I suppose the general bindings layer tests for optional arguments should be sufficient.
Attachment #8859879 - Flags: review?(cam) → review+

Comment 3

4 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a49b78b9fef5
Make the second arg of CSSOM insertRule methods optional.  r=heycam

Comment 4

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a49b78b9fef5
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.