1358116 - browser_contextmenu_input.js fails when Screenshots is enabled as an extension in tests

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Banner (:standard8)]

We're currently getting Screenshots enabled in tests. browser_contextmenu_input.js is currently failing due to various reasons:

- No id on the Screenshots menu entry
- No accesskey on the Screenshots menu entry (bug 1320462)
- Unexpected numbers of entries due Screenshots menu entry

The first one I think is a bug in WebExtensions that I'll file soon, the last one probably needs the test fixing.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1358116 - Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled.

Review commit: https://reviewboard.mozilla.org/r/134374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134374/

Comment 2

[Mark Banner (:standard8)]

There's a try server build with this patch & screenshots enabled running here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3bb8f193bd9d2d3e9ce96b77b34270c73af6461

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8862448 [details]
Bug 1358116 - Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled.

https://reviewboard.mozilla.org/r/134374/#review137472

::: browser/base/content/test/general/contextmenu_common.js:73
(Diff revision 1)
>                         item.id != "spell-no-suggestions" &&
>                         item.id != "spell-add-dictionaries-main" &&
>                         item.id != "context-savelinktopocket" &&
>                         item.id != "fill-login-saved-passwords" &&
> -                       item.id != "fill-login-no-logins") {
> +                       item.id != "fill-login-no-logins" &&
> +                       // XXX Screenshots doesn't have an ID. This needs at least

I think you mean 'access key' here instead of 'ID', since bug 1358213 is marked as fixed.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8862448 [details]
Bug 1358116 - Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/134374/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2b3ef7f8efe
Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled. r=jaws

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c2b3ef7f8efe