browser_contextmenu_input.js fails when Screenshots is enabled as an extension in tests

RESOLVED FIXED in Firefox 55

Status

()

Firefox
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Depends on: 1 bug)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We're currently getting Screenshots enabled in tests. browser_contextmenu_input.js is currently failing due to various reasons:

- No id on the Screenshots menu entry
- No accesskey on the Screenshots menu entry (bug 1320462)
- Unexpected numbers of entries due Screenshots menu entry

The first one I think is a bug in WebExtensions that I'll file soon, the last one probably needs the test fixing.
(Assignee)

Updated

a year ago
Depends on: 1358213
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
There's a try server build with this patch & screenshots enabled running here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3bb8f193bd9d2d3e9ce96b77b34270c73af6461

Comment 3

a year ago
mozreview-review
Comment on attachment 8862448 [details]
Bug 1358116 - Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled.

https://reviewboard.mozilla.org/r/134374/#review137472

::: browser/base/content/test/general/contextmenu_common.js:73
(Diff revision 1)
>                         item.id != "spell-no-suggestions" &&
>                         item.id != "spell-add-dictionaries-main" &&
>                         item.id != "context-savelinktopocket" &&
>                         item.id != "fill-login-saved-passwords" &&
> -                       item.id != "fill-login-no-logins") {
> +                       item.id != "fill-login-no-logins" &&
> +                       // XXX Screenshots doesn't have an ID. This needs at least

I think you mean 'access key' here instead of 'ID', since bug 1358213 is marked as fixed.
Attachment #8862448 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2b3ef7f8efe
Adapt browser_contextmenu* to take account of Screenshots being in the context menu when it is enabled. r=jaws

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c2b3ef7f8efe
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.