1358183 - Remove some unused PSM IDL constants and functions

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[:Cykesiopka]

There are some PSM IDL constants and functions that aren't used even in addons.
We should remove them.

Comment 1

[:Cykesiopka]

Attachment: Bug 1358183 - Remove some unused PSM IDL constants and functions.

Review commit: https://reviewboard.mozilla.org/r/135868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135868/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8864227 [details]
Bug 1358183 - Remove some unused PSM IDL constants and functions.

https://reviewboard.mozilla.org/r/135868/#review138922

LGTM - thanks!

::: security/manager/ssl/nsPK11TokenDB.cpp
(Diff revision 1)
> -
> -  nsNSSShutDownPreventionLock locker;
> -  if (isAlreadyShutDown())
> -    return NS_ERROR_NOT_AVAILABLE;
> -
> -  *_retval = PK11_IsFriendly(mSlot.get());

I think we can remove this from security/nss.symbols now, right?

Comment 3

[:Cykesiopka]

Comment on attachment 8864227 [details]
Bug 1358183 - Remove some unused PSM IDL constants and functions.

https://reviewboard.mozilla.org/r/135868/#review138922

Thanks for the review.

> I think we can remove this from security/nss.symbols now, right?

Sadly no - looks like certutil uses the function: https://treeherder.mozilla.org/#/jobs?repo=try&revision=538b688c500b1500986a48bff75c192166267118&selectedJob=96615728

Comment 4

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef2e5fa63abc2ee116b450f2d843cfc4d9d4c84b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfb9c5cf8965
Remove some unused PSM IDL constants and functions. r=keeler

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cfb9c5cf8965