Remove some unused PSM IDL constants and functions

RESOLVED FIXED in Firefox 55

Status

()

Core
Security: PSM
P1
minor
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
There are some PSM IDL constants and functions that aren't used even in addons.
We should remove them.
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8864227 [details]
Bug 1358183 - Remove some unused PSM IDL constants and functions.

https://reviewboard.mozilla.org/r/135868/#review138922

LGTM - thanks!

::: security/manager/ssl/nsPK11TokenDB.cpp
(Diff revision 1)
> -
> -  nsNSSShutDownPreventionLock locker;
> -  if (isAlreadyShutDown())
> -    return NS_ERROR_NOT_AVAILABLE;
> -
> -  *_retval = PK11_IsFriendly(mSlot.get());

I think we can remove this from security/nss.symbols now, right?
Attachment #8864227 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 3

7 months ago
mozreview-review-reply
Comment on attachment 8864227 [details]
Bug 1358183 - Remove some unused PSM IDL constants and functions.

https://reviewboard.mozilla.org/r/135868/#review138922

Thanks for the review.

> I think we can remove this from security/nss.symbols now, right?

Sadly no - looks like certutil uses the function: https://treeherder.mozilla.org/#/jobs?repo=try&revision=538b688c500b1500986a48bff75c192166267118&selectedJob=96615728
(Assignee)

Comment 4

7 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef2e5fa63abc2ee116b450f2d843cfc4d9d4c84b
Keywords: checkin-needed

Comment 5

7 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfb9c5cf8965
Remove some unused PSM IDL constants and functions. r=keeler
Keywords: checkin-needed

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cfb9c5cf8965
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.