Closed Bug 1358229 Opened 2 years ago Closed 2 years ago

optional permission prompts throw telemetry errors

Categories

(WebExtensions :: General, enhancement, P1)

enhancement

Tracking

(firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: aswan, Assigned: aswan)

Details

(Whiteboard: triaged)

Attachments

(1 file)

Code here and a few lines below generates telemetry for permissions prompts shown during extension installs and upgrades:
http://searchfox.org/mozilla-central/rev/d8ac097a1de2544f0e51d186bc850662c5b7430a/browser/modules/ExtensionsUI.jsm#400

We use the same code for optional permission prompts but we have not defined histogram categories for optional permisisons.  The easy fix is to just skip the telemetry gathering for optional prompts.  Or do we want to gather telemetry on reponses to optional permission prompts?
Flags: needinfo?(amckay)
It would be nice, but not required if its complicated.
Flags: needinfo?(amckay)
Priority: -- → P1
Whiteboard: triaged
Attachment #8861110 - Flags: review?(rhelmer)
Comment on attachment 8861110 [details]
Bug 1358229 Fix exception during optional permission prompts

https://reviewboard.mozilla.org/r/133068/#review135868
Attachment #8861110 - Flags: review?(rhelmer) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbcaa8718c74
Fix exception during optional permission prompts r=rhelmer
https://hg.mozilla.org/mozilla-central/rev/fbcaa8718c74
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.