1358229 - optional permission prompts throw telemetry errors

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Andrew Swan [:aswan]]

Code here and a few lines below generates telemetry for permissions prompts shown during extension installs and upgrades:
http://searchfox.org/mozilla-central/rev/d8ac097a1de2544f0e51d186bc850662c5b7430a/browser/modules/ExtensionsUI.jsm#400

We use the same code for optional permission prompts but we have not defined histogram categories for optional permisisons.  The easy fix is to just skip the telemetry gathering for optional prompts.  Or do we want to gather telemetry on reponses to optional permission prompts?

Comment 1

[Andy McKay]

It would be nice, but not required if its complicated.

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1358229 Fix exception during optional permission prompts

Review commit: https://reviewboard.mozilla.org/r/133068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133068/

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 8861110 [details]
Bug 1358229 Fix exception during optional permission prompts

https://reviewboard.mozilla.org/r/133068/#review135868

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbcaa8718c74
Fix exception during optional permission prompts r=rhelmer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fbcaa8718c74