Closed
Bug 1358246
Opened 7 years ago
Closed 7 years ago
Missing syntax error for object property with leading "async"
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
4.66 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Test case: --- ({async async: 0}); --- Expected: Throws SyntaxError Actual: No SyntaxError thrown
Assignee | ||
Comment 1•7 years ago
|
||
Report an error if |async <property-name>| was parsed, but the trailing source text cannot be parsed as an async method. And I've moved the TOK_STRING case to appear before the default case, because it's confusing to have case-statements after the default case.
Comment 2•7 years ago
|
||
Comment on attachment 8860624 [details] [diff] [review] bug1358246.patch Review of attachment 8860624 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/frontend/Parser.cpp @@ +9619,5 @@ > + propName = stringLiteral(); > + if (!propName) > + return null(); > + break; > + } Rather strange that we had this below default:
Attachment #8860624 -
Flags: review?(shu) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27f3061caa7cc2c908cd282cd77eee795c037fde
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/999318b53733 Report syntax error for stray "async" keyword in object literal property name. r=shu
Keywords: checkin-needed
Comment 5•7 years ago
|
||
Backed out bug 1358246, bug 1354974 and bug 1317383 for failing various tests in different test suites: Bug 1317383 https://hg.mozilla.org/integration/mozilla-inbound/rev/edaf81997a7bd28d3fd6c1955ef52b837b183ff5 https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2539cd72c91ae71633c8aea460577e1120647c https://hg.mozilla.org/integration/mozilla-inbound/rev/4cb0cfe2b32ef6c3ad3096b2cbfca879d375e5da https://hg.mozilla.org/integration/mozilla-inbound/rev/12a29d618d6eb7ed27c0e8f3b1ce551fa8ef0880 Bug 1354974 https://hg.mozilla.org/integration/mozilla-inbound/rev/dc19ec159be24735c18f3afdee00c6b9c881b39f Bug 1358246 https://hg.mozilla.org/integration/mozilla-inbound/rev/2baf4e5a516aa6a8eb7ca7080dc7d8c8f41e5c25 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=999318b53733c5ccef06fcf87025cf00d515b0af&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Most of the failures look related to bug 1317383, but not sure about these failures in wpt's /_mozilla/wasm/jsapi.js.html: https://treeherder.mozilla.org/logviewer.html#?job_id=95206554&repo=mozilla-inbound [task 2017-04-28T13:53:40.253238Z] 13:53:40 INFO - TEST-PASS | /_mozilla/wasm/jsapi.js.html | unexpected success in assertInstantiateError [task 2017-04-28T13:53:40.253621Z] 13:53:40 INFO - TEST-PASS | /_mozilla/wasm/jsapi.js.html | unexpected success in assertInstantiateError [task 2017-04-28T13:53:40.253707Z] 13:53:40 INFO - TEST-UNEXPECTED-FAIL | /_mozilla/wasm/jsapi.js.html | unexpected success in assertInstantiateError - assert_equals: expected true but got false [task 2017-04-28T13:53:40.254089Z] 13:53:40 INFO - assertInstantiateError/</<@http://web-platform.test:8000/_mozilla/wasm/js/jsapi.js:725:21 [task 2017-04-28T13:53:40.254159Z] 13:53:40 INFO - Async*assertInstantiateError/<@http://web-platform.test:8000/_mozilla/wasm/js/jsapi.js:719:20 [task 2017-04-28T13:53:40.254558Z] 13:53:40 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20 [task 2017-04-28T13:53:40.254628Z] 13:53:40 INFO - promise callback*promise_test@http://web-platform.test:8000/resources/testharness.js:529:31 [task 2017-04-28T13:53:40.254728Z] 13:53:40 INFO - assertInstantiateError@http://web-platform.test:8000/_mozilla/wasm/js/jsapi.js:718:9 [task 2017-04-28T13:53:40.254790Z] 13:53:40 INFO - @http://web-platform.test:8000/_mozilla/wasm/js/jsapi.js:744:5 [task 2017-04-28T13:53:40.255032Z] 13:53:40 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1409:20 [task 2017-04-28T13:53:40.255709Z] 13:53:40 INFO - test@http://web-platform.test:8000/resources/testharness.js:501:9 [task 2017-04-28T13:53:40.255779Z] 13:53:40 INFO - testJSAPI@http://web-platform.test:8000/_mozilla/wasm/js/jsapi.js:711:1 [task 2017-04-28T13:53:40.255880Z] 13:53:40 INFO - @http://web-platform.test:8000/_mozilla/wasm/js/jsapi.js:17:11 [task 2017-04-28T13:53:40.256403Z] 13:53:40 INFO - Looks like the stack changed: https://dxr.mozilla.org/mozilla-central/rev/2cca333f546f38860f84940d4c72d7470a3410f4/testing/web-platform/mozilla/tests/wasm/js/jsapi.js#725
Flags: needinfo?(andrebargull)
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/de04eca510ed Report syntax error for stray "async" keyword in object literal property name. r=shu
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/de04eca510ed
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•