1358360 - The SharedLibrary object for the main executable on linux has empty debugName and breakpadId fields

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Markus Stange [:mstange]]

The debugName should be set to the filename portion of the debugPath, and getId needs to be called to obtain its breakpadId.
The name and path fields should be set to the same values as debugName and debugPath.

Once these pieces of information are present, perf.html should be able to symbolicate functions from the main executable properly.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1358360 - Correctly fill in SharedLibrary fields for the main executable.

Review commit: https://reviewboard.mozilla.org/r/132492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132492/

Comment 2

[Julian Seward [:jseward]]

Comment on attachment 8860492 [details]
Bug 1358360 - Correctly fill in SharedLibrary fields for the main executable.

Nice fix + tidying.

Comment 3

[Julian Seward [:jseward]]

Comment on attachment 8860492 [details]
Bug 1358360 - Correctly fill in SharedLibrary fields for the main executable.

https://reviewboard.mozilla.org/r/132492/#review136032

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8860492 [details]
Bug 1358360 - Correctly fill in SharedLibrary fields for the main executable.

https://reviewboard.mozilla.org/r/132492/#review136292

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d53996bf124
Correctly fill in SharedLibrary fields for the main executable. r=jseward

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5d53996bf124