1358368 - Intermittent toolkit/components/places/tests/favicons/test_root_icons.js | test_removePagesByTimeframe - [test_removePagesByTimeframe : 84] There should be no icon entry - 1 == 0

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=93191744&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64/1492740268/mozilla-inbound_yosemite_r7_test-xpcshell-bm135-tests1-macosx-build392.txt.gz

Comment 1

[Marco Bonardo [:mak]]

Taking for investigation

Comment 2

[Marco Bonardo [:mak]]

my only suspect so far is that the concurrent connection is reading from the db while the db is checkpointing the change, that means it reads an outdated snapshot. adding a promiseUpdatePlaces may do in such a case.
I cannot reproduce locally.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1358368 - Ensure we read values from a current db snapshot in places/tests/favicons/test_root_icons.js.

Review commit: https://reviewboard.mozilla.org/r/132386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132386/

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8860343 [details]
Bug 1358368 - Ensure we read values from a current db snapshot in places/tests/favicons/test_root_icons.js.

https://reviewboard.mozilla.org/r/132386/#review135260

This seems reasonable to try. r=Standard8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dea1c646413a
Ensure we read values from a current db snapshot in places/tests/favicons/test_root_icons.js. r=standard8

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dea1c646413a