Closed Bug 1358418 Opened 3 years ago Closed 3 years ago

Be more informative about which file ESLint is failing on when getASTSource() hits a computed member expression

Categories

(Firefox Build System :: Lint and Formatting, defect)

3 Branch
defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Currently, when we hit a computed MemberExpression in the helpers.getASTSource() function, we give quite a useless error message:

$ ./mach eslint --no-ignore testing/talos/talos/tests
getASTSource unsupported computed MemberExpression
Error: getASTSource unsupported computed MemberExpression
    at Object.getASTSource (/Users/mark/dev/gecko/node_modules/eslint-plugin-mozilla/lib/helpers.js:88:17)
    at EventEmitter.CallExpression (/Users/mark/dev/gecko/node_modules/eslint-plugin-mozilla/lib/rules/avoid-removeChild.js:37:19)
    at emitOne (events.js:101:20)
    at EventEmitter.emit (events.js:191:7)
    at NodeEventGenerator.applySelector (/Users/mark/dev/gecko/node_modules/eslint/lib/util/node-event-generator.js:265:26)
    at NodeEventGenerator.applySelectors (/Users/mark/dev/gecko/node_modules/eslint/lib/util/node-event-generator.js:294:22)
    at NodeEventGenerator.enterNode (/Users/mark/dev/gecko/node_modules/eslint/lib/util/node-event-generator.js:308:14)
    at CodePathAnalyzer.enterNode (/Users/mark/dev/gecko/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:602:23)
    at CommentEventGenerator.enterNode (/Users/mark/dev/gecko/node_modules/eslint/lib/util/comment-event-generator.js:98:23)
    at Traverser.enter (/Users/mark/dev/gecko/node_modules/eslint/lib/eslint.js:929:36)

We should be able to give at least the file name of the file causing the issue (in this case its /Users/mark/dev/gecko/testing/talos/talos/tests/canvasmark/scripts/jquery-1.4.2.min.js) - I believe that we generally hit these on vendor minified files.
Comment on attachment 8860870 [details]
Bug 1358418 - Be more informative about which file ESLint is failing on when getASTSource() hits a computed member expression.

https://reviewboard.mozilla.org/r/132884/#review135848
Attachment #8860870 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93bf1142be38
Be more informative about which file ESLint is failing on when getASTSource() hits a computed member expression. r=mossop
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a96b9b020f1c
Backed out changeset 93bf1142be38 for ml failure
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d5af288c869
Be more informative about which file ESLint is failing on when getASTSource() hits a computed member expression. r=Mossop
https://hg.mozilla.org/mozilla-central/rev/0d5af288c869
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.