1358487 - Native form validation error messages do not appear

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Peter-Paul Koch]

Attachment: Simple test form which ought to show a validation error message when the user hits Submit.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce:

See https://quirksmode.org/dom/forms/firefoxbug.html. Simple test form which ought to show a validation error message when the user hits Submit. File also attached.

New bug since Firefox 53. The test works fine in 52.


Actual results:

On submit the field shows no error message.


Expected results:

On submit the field shows the error message.

Comment 1

[Mike Taylor [:miketaylr]]

I can reproduce this with a clean profile in 53, but not in a clean profile in 54.

Mike, do you know where the best place for this bug to live is?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Bug 345624 was where the initial work to support validation was done, and that was in Core :: DOM: Core & HTML, so let's put it there for now.

Comment 3

[Alice0775 White]

Regression window in beta:
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=a5ccc32310c9a424ccb4f5106f5155ca20dd360a&tochange=ea823a8262ac96b7150df0a41beb2ba5e40fe89c

Regression window in inbound:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5b38cc764e9012ec544cc3b150c35db706e34ced&tochange=d280a7a149bba92ecdb59b9de0a0336c336de889

Regressed by: Bug 1109868

Fixed window in autoland:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dbc95156d490db31e79770dbb245cf7bb06e2b09&tochange=0ee3593e23151e498f26f7fb9af07035272ebbce

Fixed by: Bug 1341190

Comment 4

[Alice0775 White]

Mozilla forgot to uplift Bug 1341190 to 53  :(

Comment 5

[Mike Taylor [:miketaylr]]

Thanks for finding the regression bug Alice0775! 

Not sure what our options are here short of living with this regression until 54 ships. Liz, something to put on the radar in case we ship a dot release? Kind of sucks to break html5 form validation UI.

Comment 6

[Peter-Paul Koch]

Since I'm writing an article on this topic and I have to say something about this bug, it is fair to say that this is a bug in Firefox 53 that does not occur in either 52 or 54, correct?

Comment 8

[Mike Taylor [:miketaylr]]

> it is fair to say that this is a bug in Firefox 53 that does not occur in either 52 or 54, correct?

That sounds correct. It's hard to say if this might be fixed in an upcoming 53 dot release or not (release management will have to decide), but it's def. fixed in 54.

Comment 9

[Kohei Yoshino [:kohei]]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/form-validation-error-messages-disappear-quickly/

[Tracking Requested - why for this release]: A site compatibility regression affecting certain web forms using the validation API properly. The patch in Bug 1341190 seems one-liner CSS; the uplift risk should be very low.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Yes, this looks like a great candidate for a 53 dot release if we do one, which is likely.

Comment 12

[Andy Mercer]

Been over a week now. Any updates on if this is going to be a dot release?

Comment 13

[Mike Conley (:mconley) (:⚙️)]

ni? for comment 12

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Handling this now in bug 1341190 where the uplift request is.

Comment 15

[Kohei Yoshino [:kohei]]

Fixed with Firefox 53.0.2 shipped today.