1358493 - Android Trunk Nightlys broken with SyntaxError: invalid syntax in multilocale builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=93287341&repo=mozilla-central&lineNumber=23105

Traceback (most recent call last):
[task 2017-04-21T11:29:14.254388Z] 11:29:14     INFO -    File "build/src/testing/mozharness/scripts/multil10n.py", line 17, in <module>
[task 2017-04-21T11:29:14.254565Z] 11:29:14     INFO -      from mozharness.mozilla.l10n.multi_locale_build import MultiLocaleBuild
[task 2017-04-21T11:29:14.254826Z] 11:29:14     INFO -    File "/home/worker/workspace/build/src/testing/mozharness/mozharness/mozilla/l10n/multi_locale_build.py", line 20, in <module>
[task 2017-04-21T11:29:14.255012Z] 11:29:14     INFO -      from mozharness.base.vcs.vcsbase import MercurialScript
[task 2017-04-21T11:29:14.255254Z] 11:29:14     INFO -    File "/home/worker/workspace/build/src/testing/mozharness/mozharness/base/vcs/vcsbase.py", line 18, in <module>
[task 2017-04-21T11:29:14.255428Z] 11:29:14     INFO -      from mozharness.base.script import BaseScript
[task 2017-04-21T11:29:14.255632Z] 11:29:14     INFO -    File "/home/worker/workspace/build/src/testing/mozharness/mozharness/base/script.py", line 474
[task 2017-04-21T11:29:14.255823Z] 11:29:14     INFO -      with gzip.open(file_name + '.gz', 'rb') as f_in, open(file_name, 'wb') as f_out:
[task 2017-04-21T11:29:14.255996Z] 11:29:14     INFO -                                                     ^
[task 2017-04-21T11:29:14.256164Z] 11:29:14     INFO -  SyntaxError: invalid syntax
[task 2017-04-21T11:29:14.256349Z] 11:29:14    ERROR - Return code: 1
[task 2017-04-21T11:29:14.257064Z] 11:29:14    ERROR - 1 not in success codes: [0]
[task 2017-04-21T11:29:14.257335Z] 11:29:14  WARNING - setting return code to 2
[task 2017-04-21T11:29:14.257552Z] 11:29:14    FATAL - Halting on failure while running ['python', 'build/src/testing/mozharness/scripts/multil10n.py', '--config-file', 'multi_locale/mozilla-central_android.json', '--config-file', 'multi_locale/android-mozharness-build.json', '--merge-locales', '--pull-locale-source', '--add-locales', '--package-multi', '--summary']
[task 2017-04-21T11:29:14.257798Z] 11:29:14    FATAL - Running post_fatal callback...
[task 2017-04-21T11:29:14.258104Z] 11:29:14    FATAL - Exiting 2

Comment 1

[Rail Aliiev [:rail]]

looks like https://hg.mozilla.org/mozilla-central/rev/35ef9cd54519

Comment 2

[Carsten Book [:Tomcat]]

fixed by backing out bug 1358142 will retrigger android nightlys also now

Comment 3

[Pete Moore [:pmoore][:pete]]

Thanks Rail, Tomcat!

Do you know which version of python is used by nightlies? On 2.7.13, this seems to be ok - are we on an earlier version of 2.7?



$ python
Python 2.7.13 (default, Dec 17 2016, 23:03:43) 
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import gzip
>>> import shutil
>>> file_name='abc'
>>> with gzip.open(file_name + '.gz', 'rb') as f_in, open(file_name, 'wb') as f_out:
...     shutil.copyfileobj(f_in, f_out)
... 
>>> quit()


Thanks!

Comment 4

[Rail Aliiev [:rail]]

I'm on pto today, but multi locale uses py2.6 for that part, but only that part, there is a bug on file. 

It might not be hard to fix, and is testable in TC, since it exists there too. 

- Justin Wood  (callek)

Comment 5

[Pete Moore [:pmoore][:pete]]

Thanks Rail / Callek! :-)

I've relanded an alternative patch that should be compatible with python 2.6.