Closed
Bug 1358504
Opened 7 years ago
Closed 7 years ago
Add a 1-entry cache to ObjectGroup::defaultNewGroup
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
9.10 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
ObjectGroup::defaultNewGroup often shows up in profiles. The attached patch adds a 1-entry cache. It's pretty effective: when I open the browser and load Gmail, I get 290154 cache hits for 428747 lookups, so about 67% hit rate. I see similar results on various shell benchmarks and other websites.
Attachment #8860414 -
Flags: review?(bhackett1024)
|
||
Updated•7 years ago
|
Attachment #8860414 -
Flags: review?(bhackett1024) → review+
|
||
Updated•7 years ago
|
Whiteboard: [qf]
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e0405aef6cff Add a 1-entry cache to ObjectGroup::defaultNewGroup. r=bhackett
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e0405aef6cff
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•2 years ago
|
Performance Impact: --- → ?
Whiteboard: [qf]
You need to log in
before you can comment on or make changes to this bug.
Description
•