1358592 - Dynamic Toolbar v3 breaks back button rendering on android tablets

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Randall Barker [:rbarker]]

The back button is rendered incorrectly on android tables. Caused by changes made by Dynamic Toolbar v3.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1358592 - Dynamic Toolbar v3 breaks back button rendering on android tablets

Review commit: https://reviewboard.mozilla.org/r/132528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132528/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8860523 [details]
Bug 1358592 - Dynamic Toolbar v3 breaks back button rendering on android tablets

https://reviewboard.mozilla.org/r/132528/#review135432

::: commit-message-5ed2f:1
(Diff revision 1)
> +Bug 1358592 - Dynamic Toolbar v3 breaks back button rendering on android tablets r=esawin

Commit message should explain why this fixes the issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be2b31d3290e
Dynamic Toolbar v3 breaks back button rendering on android tablets r=esawin

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/be2b31d3290e

Comment 5

[Chris Peterson [:cpeterson]]

Moving toolbar bugs to the new GeckoView::Toolbar component.