|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
STR: 1. Open about:preferences#privacy 2. Click the "Exceptions" button. 3. See the "Exceptions - Saved Logins" dialog open and dim the preference page background (like a web page lightbox). 4. Try to dismiss the dialog lightbox by clicking the dim background. RESULT: Nothing happens. You can only dismiss the dialog by clicking its X close button. Since the preference dialogs look like web page lightboxes, they should probably follow the common lightbox UX convention of dismissing the lightbox when the dim background is clicked.
Comment on attachment 8863262 [details] Bug 1358645 - Close the preference dialog when the user clicks the overlay background. https://reviewboard.mozilla.org/r/135044/#review138446 Clearing review, because, in no particular order: - this needs to also update the in-content-old code and tests - this should be reviewed by :jaws or :mconley per https://groups.google.com/forum/?fromgroups=&hl=en#!topic/firefox-dev/J8GvR2wxoOc - this should get a UI/UX review. I assume there is some reason we didn't implement this to start with, or perhaps there is other extant code that is supposed to do this that's broken somehow. Either way, I am surprised - maybe Jared or Matt have more context.
Thanks for your feedback and for pointing out the in-content-old code, Gijs. I'll follow up with UI/UX.
Comment on attachment 8863262 [details] Bug 1358645 - Close the preference dialog when the user clicks the overlay background. https://reviewboard.mozilla.org/r/135044/#review141212
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b8e7b44f3050 Close the preference dialog when the user clicks the overlay background. r=jaws
I have reproduced this bug on Nightly according to (2017-04-21) Fixing bug is verified on Latest Nightly -- Build ID: 20170517030204,User Agent: Mozilla/5.0 (Windows NT 6.1; rv:55.0) Gecko/20100101 Firefox/55.0 Tested OS-- Windows7 32bit
I have reproduced this bug with Nightly 55.0a1 (2017-04-21) on Ubuntu 16.04, 64 Bit! The fix is now verified on latest Nightly! Build ID 20170523100217 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170524]