1358645 - about:preferences subdialog should be dismissable by clicking the overlay background (like a web page lightbox)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Open about:preferences#privacy
2. Click the "Exceptions" button.
3. See the "Exceptions - Saved Logins" dialog open and dim the preference page background (like a web page lightbox).
4. Try to dismiss the dialog lightbox by clicking the dim background.

RESULT:
Nothing happens. You can only dismiss the dialog by clicking its X close button. Since the preference dialogs look like web page lightboxes, they should probably follow the common lightbox UX convention of dismissing the lightbox when the dim background is clicked.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1358645 - Close the preference dialog when the user clicks the overlay background.

Review commit: https://reviewboard.mozilla.org/r/135044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135044/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8863262 [details]
Bug 1358645 - Close the preference dialog when the user clicks the overlay background.

https://reviewboard.mozilla.org/r/135044/#review138446

Clearing review, because, in no particular order:
- this needs to also update the in-content-old code and tests
- this should be reviewed by :jaws or :mconley per https://groups.google.com/forum/?fromgroups=&hl=en#!topic/firefox-dev/J8GvR2wxoOc
- this should get a UI/UX review. I assume there is some reason we didn't implement this to start with, or perhaps there is other extant code that is supposed to do this that's broken somehow. Either way, I am surprised - maybe Jared or Matt have more context.

Comment 3

[Chris Peterson [:cpeterson]]

Thanks for your feedback and for pointing out the in-content-old code, Gijs. I'll follow up with UI/UX.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 8863262 [details]
Bug 1358645 - Close the preference dialog when the user clicks the overlay background.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135044/diff/1-2/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8863262 [details]
Bug 1358645 - Close the preference dialog when the user clicks the overlay background.

https://reviewboard.mozilla.org/r/135044/#review141212

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8e7b44f3050
Close the preference dialog when the user clicks the overlay background. r=jaws

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b8e7b44f3050

Comment 8

[Saheda Reza [:Antora]]

I have reproduced this bug on Nightly according to (2017-04-21)

Fixing bug is verified on Latest Nightly -- Build ID: 20170517030204,User Agent: Mozilla/5.0 (Windows NT 6.1; rv:55.0) Gecko/20100101 Firefox/55.0

Tested OS-- Windows7 32bit

Comment 9

[Tanvir Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-04-21) on Ubuntu 16.04, 64 Bit!

The fix is now verified on latest Nightly!

Build ID 	20170523100217
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170524]

Comment 10

[Tanvir Rahman]

As per Comment 8 & Comment 9, I am marking this bug as verified fixed.