If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

about:preferences subdialog should be dismissable by clicking the overlay background (like a web page lightbox)

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Preferences
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox53 wontfix, firefox54 wontfix, firefox55 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
STR:
1. Open about:preferences#privacy
2. Click the "Exceptions" button.
3. See the "Exceptions - Saved Logins" dialog open and dim the preference page background (like a web page lightbox).
4. Try to dismiss the dialog lightbox by clicking the dim background.

RESULT:
Nothing happens. You can only dismiss the dialog by clicking its X close button. Since the preference dialogs look like web page lightboxes, they should probably follow the common lightbox UX convention of dismissing the lightbox when the dim background is clicked.
(Assignee)

Updated

5 months ago
Assignee: nobody → cpeterson
Summary: about:preferences dialog box should be able to be dismissed by clicking the dim background like lightbox page → about:preferences subdialog should be dismissable by clicking the overlay background (like a web page lightbox)
Comment hidden (mozreview-request)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8863262 [details]
Bug 1358645 - Close the preference dialog when the user clicks the overlay background.

https://reviewboard.mozilla.org/r/135044/#review138446

Clearing review, because, in no particular order:
- this needs to also update the in-content-old code and tests
- this should be reviewed by :jaws or :mconley per https://groups.google.com/forum/?fromgroups=&hl=en#!topic/firefox-dev/J8GvR2wxoOc
- this should get a UI/UX review. I assume there is some reason we didn't implement this to start with, or perhaps there is other extant code that is supposed to do this that's broken somehow. Either way, I am surprised - maybe Jared or Matt have more context.
Attachment #8863262 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Comment 3

5 months ago
Thanks for your feedback and for pointing out the in-content-old code, Gijs. I'll follow up with UI/UX.
Comment hidden (mozreview-request)

Comment 5

5 months ago
mozreview-review
Comment on attachment 8863262 [details]
Bug 1358645 - Close the preference dialog when the user clicks the overlay background.

https://reviewboard.mozilla.org/r/135044/#review141212
Attachment #8863262 - Flags: review?(jaws) → review+

Comment 6

5 months ago
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8e7b44f3050
Close the preference dialog when the user clicks the overlay background. r=jaws
https://hg.mozilla.org/mozilla-central/rev/b8e7b44f3050
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 8

4 months ago
I have reproduced this bug on Nightly according to (2017-04-21)

Fixing bug is verified on Latest Nightly -- Build ID: 20170517030204,User Agent: Mozilla/5.0 (Windows NT 6.1; rv:55.0) Gecko/20100101 Firefox/55.0

Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20170517]
status-firefox54: affected → wontfix

Comment 9

4 months ago
I have reproduced this bug with Nightly 55.0a1 (2017-04-21) on Ubuntu 16.04, 64 Bit!

The fix is now verified on latest Nightly!

Build ID 	20170523100217
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170524]
QA Whiteboard: [bugday-20170517] → [bugday-20170517], [bugday-20170524]

Comment 10

4 months ago
As per Comment 8 & Comment 9, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.