Closed Bug 1358725 Opened 4 years ago Closed 4 years ago

Release OpenVR controller axis should return zero

Categories

(Core :: WebVR, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(1 file)

We should add an array at VRControllerOpenVR to store the latest value of axis move instead of just checking the value is not equal with zero [1]. 

[1] https://dxr.mozilla.org/mozilla-central/rev/c8198aa6e7677e90cc7f1e2df0a14a5cc2719055/gfx/vr/gfxVROpenVR.cpp#809
Blocks: 1299926
Assignee: nobody → dmu
Comment on attachment 8860893 [details]
Bug 1358725 - Return zero after OpenVR controllers' axis is released;

https://reviewboard.mozilla.org/r/132906/#review136532

LGTM
Attachment #8860893 - Flags: review?(kgilbert) → review+
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbc3a33ce156
Return zero after OpenVR controllers' axis is released; r=kip
https://hg.mozilla.org/mozilla-central/rev/fbc3a33ce156
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.