Release OpenVR controller axis should return zero

RESOLVED FIXED in Firefox 55

Status

()

Core
WebVR
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We should add an array at VRControllerOpenVR to store the latest value of axis move instead of just checking the value is not equal with zero [1]. 

[1] https://dxr.mozilla.org/mozilla-central/rev/c8198aa6e7677e90cc7f1e2df0a14a5cc2719055/gfx/vr/gfxVROpenVR.cpp#809
(Assignee)

Updated

a year ago
Blocks: 1299926
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → dmu

Comment 2

a year ago
mozreview-review
Comment on attachment 8860893 [details]
Bug 1358725 - Return zero after OpenVR controllers' axis is released;

https://reviewboard.mozilla.org/r/132906/#review136532

LGTM
Attachment #8860893 - Flags: review?(kgilbert) → review+

Comment 3

a year ago
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbc3a33ce156
Return zero after OpenVR controllers' axis is released; r=kip

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fbc3a33ce156
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.