1358726 - Crash in mozilla::MediaCache::AllocateAndWriteBlock

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Julian Seward [:jseward]]

This bug was filed from the Socorro interface and is 
report bp-6327caeb-d7eb-4579-a796-72e970170421.
=============================================================

This is ranked #11 in the Windows crashes for Nightly 20170420030346.

Comment 1

[Calixte Denizet (:calixte)]

This regression may have been introduced by patch [1] to fix bug 1357244.

[1] https://hg.mozilla.org/mozilla-central/rev?node=96e7a9cb5588327eba8dfa772b9675d350aea546

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1358726 - fix the assertion failure in AllocateAndWriteBlock().

block->mOwners might be empty if all streams for the resource id are
closed. We don't bother write the data to the cache since there is no
stream to use it.

Review commit: https://reviewboard.mozilla.org/r/132668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132668/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8860747 [details]
Bug 1358726 - fix the assertion failure in AllocateAndWriteBlock().

https://reviewboard.mozilla.org/r/132668/#review135526

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d62218969e31
fix the assertion failure in AllocateAndWriteBlock(). r=gerald

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d62218969e31