Closed
Bug 1358728
Opened 8 years ago
Closed 7 years ago
1.14ms uninterruptible reflow at startFind@chrome://global/content/bindings/findbar.xml:1142:13
Categories
(Toolkit :: Find Toolbar, defect, P1)
Toolkit
Find Toolbar
Tracking
()
People
(Reporter: rjward0, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ohnoreflow][reserve-photon-performance])
Here's the stack:
startFind@chrome://global/content/bindings/findbar.xml:1142:13
onFindCommand@chrome://global/content/bindings/findbar.xml:1171:18
oncommand@chrome://browser/content/browser.xul:1:1
|
||
Comment 1•8 years ago
|
||
http://searchfox.org/mozilla-central/rev/6e1c138a06a80f2bb3167d9dac050cc0fd4fb39e/toolkit/content/widgets/findbar.xml#1141
// NB: We have to focus this._findField here so tests that send
// key events can open and close the find bar synchronously.
this._findField.focus();
This comment seems to indicate that if we fixed some tests the focus call may no longer be needed anymore.
|
||
Updated•8 years ago
|
|
||
Updated•8 years ago
|
Flags: qe-verify?
Priority: -- → P2
|
||
Updated•8 years ago
|
Whiteboard: [ohnoreflow][qf][photon-performance] → [ohnoreflow][qf:p1][photon-performance]
|
|
||
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf:p1][photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
|
|
||
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
|
||
Updated•8 years ago
|
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:p2][reserve-photon-performance]
|
|
||
Comment 2•7 years ago
|
||
I can no longer reproduce a reflow in this codepath since bug 1369140 landed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
||
Updated•7 years ago
|
Iteration: --- → 55.7 - Jun 12
Priority: P3 → P1
|
||
Updated•3 years ago
|
Performance Impact: --- → P2
Whiteboard: [ohnoreflow][qf:p2][reserve-photon-performance] → [ohnoreflow][reserve-photon-performance]
You need to log in
before you can comment on or make changes to this bug.
Description
•