1358763 - Crash in mozilla::layers::PUiCompositorController::Transition

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-629458c0-a4c3-42cf-992f-4517a0170421.
=============================================================

There are 24 crashes in nightly 55 with buildid 20170421135915. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1335895.
This signature is ranked #3 in topcrash.

[1] https://hg.mozilla.org/mozilla-central/rev?node=81de9d1439b0e352729142f6aa2914674073da03

Comment 1

[Randall Barker [:rbarker]]

It looks like the CompositorVsyncScheduler is firing after the IPC channel has shutdown. The UiCompositorControllerParent is then trying to write to a dead IPC channel. I assume this is happen at shutdown. I'll need to talk with some one better versed in our IPC stack on Monday(22/4/17) to figure out the correct solution.

Comment 2

[Randall Barker [:rbarker]]

Attachment: Bug 1358763 - Prevent Android Dynamic Toolbar v3 from trying to send IPC message after shutdown

Review commit: https://reviewboard.mozilla.org/r/133108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133108/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8861155 [details]
Bug 1358763 - Prevent Android Dynamic Toolbar v3 from trying to send IPC message after shutdown

https://reviewboard.mozilla.org/r/133108/#review135926

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/85427dbc69bd
Prevent Android Dynamic Toolbar v3 from trying to send IPC message after shutdown r=kats

Comment 5

[Randall Barker [:rbarker]]

I was not able to reproduce this crash locally, however based on the stack trace the patch pushed looks like a possible fix. Please reopen if crash persists.

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/85427dbc69bd

Comment 7

[Calixte Denizet (:calixte)]

The crash is still present: there are 29 crashes from 2017-04-25 [1].

[1] https://crash-stats.mozilla.com/search/?release_channel=nightly&signature=%3Dmozilla%3A%3Alayers%3A%3AAPZCTreeManager%3A%3AInitializeDynamicToolbarAnimator&build_id=%3E20170425000000&product=FennecAndroid&version=55.0a1&date=%3E%3D2017-05-01T00%3A00%3A00.000Z&date=%3C2017-06-01T00%3A00%3A00.000Z&_sort=-date&_facets=install_time&_facets=build_id&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Please file a new bug. It gets confusing if you reopen bugs where patches have already landed.

Comment 9

[Calixte Denizet (:calixte)]

Ok, I just took into account comment 5.

Comment 10

[Randall Barker [:rbarker]]

This is actually a different crash than the one originally one reported in this bug.

Comment 11

[Randall Barker [:rbarker]]

(In reply to Calixte Denizet (:calixte) from comment #9)
> Ok, I just took into account comment 5.

Is there a new bug for this? Should be an easy fix.

Comment 12

[Calixte Denizet (:calixte)]

Done: https://bugzilla.mozilla.org/show_bug.cgi?id=1369298