1358781 - Dynamic Toolbar v3 static snapshot will sometimes get stuck off screen

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Randall Barker [:rbarker]]

Under certain conditions, the static toolbar will be hidden wile the real toolbar is visible. It isn't possible then to make it visible and part of the pages is hidden by the real toolbar.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1358781 - Android Dynamic Toolbar v3 keep the controller toolbar height in sync with the compositor toolbar height while animating

Android Dynamic Toolbar v3 toolbar height between controller
and compostior threads would get out sync during animation. Added code
to insure they stay in sync while the compositor thread is updating the
toolbar height during an animation. Also, when the controller thread was
canceling an animation, the compositor thread was not checking that it
was still animating before unlocking the toolbar.

Review commit: https://reviewboard.mozilla.org/r/132622/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132622/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8860669 [details]
Bug 1358781 - Android Dynamic Toolbar v3 keep the controller toolbar height in sync with the compositor toolbar height while animating

https://reviewboard.mozilla.org/r/132622/#review135548

::: commit-message-e0405:1
(Diff revision 1)
> +Bug 1358781 - Dynamic Toolbar v3 static snapshot will sometimes get stuck off screen r=kats

The first line of the commit message should be a brief description of the fix, not just a copy of the bug summary

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8860669 [details]
Bug 1358781 - Android Dynamic Toolbar v3 keep the controller toolbar height in sync with the compositor toolbar height while animating

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132622/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05e2b4b1847c
Android Dynamic Toolbar v3 keep the controller toolbar height in sync with the compositor toolbar height while animating r=kats

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/05e2b4b1847c

Comment 7

[Chris Peterson [:cpeterson]]

Moving toolbar bugs to the new GeckoView::Toolbar component.