1358863 - Refactor bug filer

Status: NEW

(Tree Management :: Treeherder, enhancement, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There's a number of things we could do to refactor the bug filer code:

1. Cleaning up the failure summary line happens in multiple places, and they each do things a little differently. We can move it all out into a new function that gets called in each of the places it's needed.
2. s/var/const/ in the cases where it matters.
3. Arrow functions.
4. Switch out for() loops for forEach where it works.
5. The end-to-end flow of the whole thing could probably get cleaned up a bit.

I have a branch locally to do (1), but some of my already in-progress pull requests are probably going to conflict with these changes, so I'll wait for some more of them to land before working on this too much more.

Comment 1

[Cameron Dawson [:camd]]

Cam: Check which of these are still valid after ReactJS conversion.

Comment 2

[Cameron Dawson [:camd]]

I took a look through the current ReactJS version of the BugFiler. I think #1 is still an issue. But the others were fixed at the time of conversion.

#5 is probably a matter of opinion. Hard to say what action may be necessary there. So we can leave this as a P3.

Wes: If you have a branch with #1 mostly done and it's merge-able with current master, that would be awesome to push it to origin and add a link to this bug. Though I suspect it's in the angular code which might make it more work than it's worth.