Open
Bug 1358863
Opened 7 years ago
Updated 2 months ago
Refactor bug filer
Categories
(Tree Management :: Treeherder, enhancement, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
NEW
People
(Reporter: KWierso, Unassigned)
Details
Attachments
(1 obsolete file)
There's a number of things we could do to refactor the bug filer code: 1. Cleaning up the failure summary line happens in multiple places, and they each do things a little differently. We can move it all out into a new function that gets called in each of the places it's needed. 2. s/var/const/ in the cases where it matters. 3. Arrow functions. 4. Switch out for() loops for forEach where it works. 5. The end-to-end flow of the whole thing could probably get cleaned up a bit. I have a branch locally to do (1), but some of my already in-progress pull requests are probably going to conflict with these changes, so I'll wait for some more of them to land before working on this too much more.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → wkocher
Updated•7 years ago
|
Component: Treeherder → Treeherder: Log Parsing & Classification
Updated•6 years ago
|
Assignee: kwierso → nobody
Comment 1•4 years ago
|
||
Cam: Check which of these are still valid after ReactJS conversion.
Flags: needinfo?(cdawson)
Comment 2•4 years ago
|
||
I took a look through the current ReactJS version of the BugFiler. I think #1 is still an issue. But the others were fixed at the time of conversion.
#5 is probably a matter of opinion. Hard to say what action may be necessary there. So we can leave this as a P3.
Wes: If you have a branch with #1 mostly done and it's merge-able with current master, that would be awesome to push it to origin
and add a link to this bug. Though I suspect it's in the angular code which might make it more work than it's worth.
Flags: needinfo?(cdawson)
Updated•4 years ago
|
Priority: -- → P3
Assignee | ||
Updated•2 years ago
|
Component: Treeherder: Log Parsing & Classification → TreeHerder
Comment hidden (spam) |
Updated•2 months ago
|
Attachment #9384016 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•