1358881 - uninterruptible reflow at attach/<@resource:///modules/ExtensionPopups.jsm:481:7

Status: RESOLVED WONTFIX

(WebExtensions :: Frontend, enhancement)

Description

[Florian Quèze [:florian]]

Here's the stack:

attach/<@resource:///modules/ExtensionPopups.jsm:481:7
TaskImpl_run@resource://gre/modules/Task.jsm:319:42

Comment 1

[Florian Quèze [:florian]]

The sync reflows is caused at http://searchfox.org/mozilla-central/rev/f225dbcb15ca2e38f7d434a9278a41d2340e7cf3/browser/components/extensions/ExtensionPopups.jsm#481 by

      // Store the initial height of the view, so that we never resize menu panel
      // sub-views smaller than the initial height of the menu.
      this.viewHeight = this.viewNode.boxObject.height;

But there's also a getBoundingClientRect call 3 lines later.

Comment 2

[Kris Maglione [:kmag]]

We need this geometry information at this point, so there's not much we can do to fix this.

In any case, this UI is going away in photon, so the problem will go away on its own soon enough.

Comment 3

[:Gijs (he/him)]

(In reply to Kris Maglione [:kmag] from comment #2)
> We need this geometry information at this point, so there's not much we can
> do to fix this.
> 
> In any case, this UI is going away in photon, so the problem will go away on
> its own soon enough.

Wouldn't we have the same problem with the overflow menu?

Comment 4

[Kris Maglione [:kmag]]

The overflow menu can shrink when we show the panel, so we won't need geometry information at that point after we move out of the panelUI menu.