Lower eslint cyclomatic complexity threshold in some directories

RESOLVED FIXED in Firefox 55

Status

Testing
Lint
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

Version 3
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 wontfix, firefox54 wontfix, firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
We can lower the eslint cyclomatic complexity threshold in some directories without adding eslint suppression comments in any .js source files. eslint's default complexity threshold is 20.

I see squib is suppressing some of the cyclomatic complexity warnings in browser/components source files (in bug 1356322), which is a further improvement on this bug.
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8860788 [details]
Bug 1358949 - Lower eslint cyclomatic complexity threshold in some directories.

https://reviewboard.mozilla.org/r/132744/#review135688

Looks good. Please be careful when autolanding with the version bumps, you might need to rebase some patches off latest autoland to get the correct version bumps.

The good news is I've just published a patch for bug 1348997 that should make the need for version bumps go away.
Attachment #8860788 - Flags: review?(standard8) → review+

Comment 3

10 months ago
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9abc00ad711a
Lower eslint cyclomatic complexity threshold in some directories. r=standard8

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9abc00ad711a
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.