Remove js::ProfilingGetPC()

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
AddPseudoEntry() has a single callsite which always passes nullptr for the
last argument. This means that js::ProfilingGetPC() is never called, and so can
be removed. (Even if it was called, it always returns nullptr because ipToPC()
always returns nullptr!)
(Assignee)

Comment 1

a year ago
Created attachment 8860886 [details] [diff] [review]
Remove js::ProfilingGetPC()
Attachment #8860886 - Flags: review?(shu)

Comment 2

a year ago
Comment on attachment 8860886 [details] [diff] [review]
Remove js::ProfilingGetPC()

Review of attachment 8860886 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/GeckoProfiler.h
@@ -192,5 @@
>      /* Enter wasm code */
>      void beginPseudoJS(const char* string, void* sp);
>      void endPseudoJS() { pop(); }
>  
> -    jsbytecode* ipToPC(JSScript* script, size_t ip) { return nullptr; }

Wow!
Attachment #8860886 - Flags: review?(shu) → review+
(Assignee)

Updated

a year ago
No longer depends on: 1359000

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1fa5147b7738
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.