1359053 - Reject interaction.flushEventLoop if window is discarded

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

If interaction.flushEventLoop from testing/marionette/interaction.js is called on a window, that has become or at some point during the operation will become, discared, it will hang.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1359053 - Reject interaction.flushEventLoop if window is discarded;

The window reference may have been discarded as a result of interaction.
For example, this may happen when clicking a button that deletes the
host <iframe> element containing the child window.  In this case, the
WindowProxy will set its closed property to true, to indicate that the
browsing context has been discarded.

We only want to flush the event loop of windows that exist, and so we
return early from interaction.flushEventLoop if the window has been
closed.

Review commit: https://reviewboard.mozilla.org/r/132974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132974/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Unfortunately this change does not come with any tests as the code path is only hit when the WebDriver conforming Element Click implementation is enabled, but I think the change is sane to the reader.  This change is in preparation of https://bugzilla.mozilla.org/show_bug.cgi?id=1321516.

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8860964 [details]
Bug 1359053 - Reject interaction.flushEventLoop if window is discarded;

https://reviewboard.mozilla.org/r/132974/#review136266

FYI, since the green Wd job is actually busted (I think due to a backout that James has in his backlog), I checked your change locally with an older non-busted harness revision just for sanity to see whether it does anything funky with actions tests. All is well.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/325df3ebf1a6
Reject interaction.flushEventLoop if window is discarded; r=maja_zf

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/325df3ebf1a6

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Andreas, this patch will cause merge issues for my click+pageload patch to uplift to beta. I think that beside that it would even fix a hang in case frames get closed, so it might be a good candidate to uplift any way, or?

Comment 7

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #6)
> Andreas, this patch will cause merge issues for my click+pageload patch to
> uplift to beta. I think that beside that it would even fix a hang in case
> frames get closed, so it might be a good candidate to uplift any way, or?

Seems reasonable to me to uplift this, and I estimate the risk of uplifting
this as minimal.

Sheriffs: Please uplift this to beta as test-only.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cff5c81e36de