Closed Bug 1359053 Opened 2 years ago Closed 2 years ago
.flush Event Loop if window is discarded
59 bytes, text/x-review-board-request
If interaction.flushEventLoop from testing/marionette/interaction.js is called on a window, that has become or at some point during the operation will become, discared, it will hang.
Unfortunately this change does not come with any tests as the code path is only hit when the WebDriver conforming Element Click implementation is enabled, but I think the change is sane to the reader. This change is in preparation of https://bugzilla.mozilla.org/show_bug.cgi?id=1321516.
Comment on attachment 8860964 [details] Bug 1359053 - Reject interaction.flushEventLoop if window is discarded; https://reviewboard.mozilla.org/r/132974/#review136266 FYI, since the green Wd job is actually busted (I think due to a backout that James has in his backlog), I checked your change locally with an older non-busted harness revision just for sanity to see whether it does anything funky with actions tests. All is well.
Attachment #8860964 - Flags: review?(mjzffr) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/325df3ebf1a6 Reject interaction.flushEventLoop if window is discarded; r=maja_zf
Andreas, this patch will cause merge issues for my click+pageload patch to uplift to beta. I think that beside that it would even fix a hang in case frames get closed, so it might be a good candidate to uplift any way, or?
(In reply to Henrik Skupin (:whimboo) from comment #6) > Andreas, this patch will cause merge issues for my click+pageload patch to > uplift to beta. I think that beside that it would even fix a hang in case > frames get closed, so it might be a good candidate to uplift any way, or? Seems reasonable to me to uplift this, and I estimate the risk of uplifting this as minimal. Sheriffs: Please uplift this to beta as test-only.
You need to log in before you can comment on or make changes to this bug.