|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Shadow DOM is not taken into account when calling element.getPointerInteractablePaintTree from testing/marionette/element.js.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Unfortunately this change is also not accompanied by any tests because the wrong behaviour does not trigger unless you run the WebDriver conforming Element Click implementation against the shadow DOM tests. This is a patch in preparation of https://bugzilla.mozilla.org/show_bug.cgi?id=1321516, but I think it is mostly sane to the reader.
Don't we have those tests in test_click.py? I can see two types and I thought that those cover that.
(In reply to Henrik Skupin (:whimboo) from comment #3) > Don't we have those tests in test_click.py? I can see two types and I > thought that those cover that. The shadow DOM related tests live in testing/marionette/harness/marionette_harness/tests/unit/test_shadow_dom.py and IIRC test_inner_shadow_dom fails if you run it with the patched webdriverClick command found in the patches attached to https://bugzilla.mozilla.org/show_bug.cgi?id=1321516.
Comment on attachment 8860966 [details] Bug 1359054 - Take shadow DOM into account when getting paint tree; https://reviewboard.mozilla.org/r/132978/#review136268 *reads Shadow DOM 101* Okay, this change makes sense! :D
Attachment #8860966 - Flags: review?(mjzffr) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/3756fa6062d1 Take shadow DOM into account when getting paint tree; r=maja_zf
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.