Closed
Bug 1359077
Opened 7 years ago
Closed 7 years ago
Optimize ExposeGCThingToActiveJS
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
4.25 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Most of these functions are inlined but the GCCellPtr::mayBeOwnedByOtherRuntime call is not and this often shows up in profiles. This patch has a few small optimizations: * mayBeOwnedByOtherRuntime is now inlined and calls an out-of-line function only for strings and symbols. I added some logging and when I load Gmail the string/symbol cases only account for a few % so it seems worth it. * I split CellIsMarkedGray in CellIsMarkedGray + TenuredCellIsMarkedGray so we can call TenuredCellIsMarkedGray when we already know the cell is tenured.
Attachment #8860974 -
Flags: review?(jcoppeard)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8860974 [details] [diff] [review] Patch Review of attachment 8860974 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks for the patch.
Attachment #8860974 -
Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b66d004acdcf Optimize a few things in ExposeGCThingToActiveJS. r=jonco
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b66d004acdcf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•2 years ago
|
Performance Impact: --- → ?
Whiteboard: [qf]
You need to log in
before you can comment on or make changes to this bug.
Description
•