Closed Bug 1359077 Opened 4 years ago Closed 4 years ago

Optimize ExposeGCThingToActiveJS

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qf])

Attachments

(1 file)

Attached patch PatchSplinter Review
Most of these functions are inlined but the GCCellPtr::mayBeOwnedByOtherRuntime call is not and this often shows up in profiles. This patch has a few small optimizations:

* mayBeOwnedByOtherRuntime is now inlined and calls an out-of-line function only for strings and symbols. I added some logging and when I load Gmail the string/symbol cases only account for a few % so it seems worth it.

* I split CellIsMarkedGray in CellIsMarkedGray + TenuredCellIsMarkedGray so we can call TenuredCellIsMarkedGray when we already know the cell is tenured.
Attachment #8860974 - Flags: review?(jcoppeard)
Blocks: 1351769
Whiteboard: [qf]
Comment on attachment 8860974 [details] [diff] [review]
Patch

Review of attachment 8860974 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks for the patch.
Attachment #8860974 - Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b66d004acdcf
Optimize a few things in ExposeGCThingToActiveJS. r=jonco
https://hg.mozilla.org/mozilla-central/rev/b66d004acdcf
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.