Inline the ToWindowProxyIfWindow is-global check

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [qf])

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Created attachment 8861000 [details] [diff] [review]
Patch

Proxy::get and Proxy::set call ToWindowProxyIfWindow. This patch adds the fast path we have for IsWindow also to ToWindowProxyIfWindow, so we can inline the non-global case.

Having that call is still sad because JS code should never pass a Window directly, but at least the overhead is much smaller now.
Attachment #8861000 - Flags: review?(evilpies)

Updated

9 months ago
Attachment #8861000 - Flags: review?(evilpies) → review+

Comment 1

9 months ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e76637092bf
Inline the ToWindowProxyIfWindow is-global check. r=evilpie

Comment 2

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e76637092bf
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.