Closed
Bug 1359093
Opened 7 years ago
Closed 7 years ago
Inline the ToWindowProxyIfWindow is-global check
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.85 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
Proxy::get and Proxy::set call ToWindowProxyIfWindow. This patch adds the fast path we have for IsWindow also to ToWindowProxyIfWindow, so we can inline the non-global case. Having that call is still sad because JS code should never pass a Window directly, but at least the overhead is much smaller now.
Attachment #8861000 -
Flags: review?(evilpies)
|
||
Updated•7 years ago
|
Attachment #8861000 -
Flags: review?(evilpies) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3e76637092bf Inline the ToWindowProxyIfWindow is-global check. r=evilpie
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e76637092bf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•2 years ago
|
Performance Impact: --- → ?
Whiteboard: [qf]
You need to log in
before you can comment on or make changes to this bug.
Description
•