1359098 - Crash in java.lang.NoSuchMethodError: android.content.Context.getDrawable at org.mozilla.gecko.customtabs.ActionBarPresenter.initIndicator(ActionBarPresenter.java)

Status: RESOLVED FIXED

(Firefox for Android :: General, defect, P1, critical)

Description

[Marcia Knous [:marcia - needinfo? me]]

This bug was filed from the Socorro interface and is 
report bp-5f88c5b8-180a-4f51-9415-a1ae32170411.
=============================================================

Seen while looking at nightly crash data - appears to have started with 20170410100159. Affects a limited subset of devices all running Kit Kat: http://bit.ly/2oEyEjY

Looks to be related to Custom Tabs feature. ni on Julian.

Comment 1

[Julian Chu [:walkingice]]

Thank you Marcia! I will fix it ASAP.

Comment 2

[Julian Chu [:walkingice]]

Attachment: Bug 1359098 - fix getDrawable method missing problem in CustomTabs

The method Context.getDrawable was introduced in API 21. To be
compatible with Kitkat, should use Resources.getDrawable instead.

Review commit: https://reviewboard.mozilla.org/r/133222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133222/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8861269 [details]
Bug 1359098 - fix getDrawable method missing problem in CustomTabs

https://reviewboard.mozilla.org/r/133222/#review136012

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3990c7af15b
fix getDrawable method missing problem in CustomTabs r=nechen

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d3990c7af15b