Closed Bug 1359111 Opened 8 years ago Closed 8 years ago

BrowserUtils.jsm's makeURI method just adds overhead

Categories

(Toolkit :: General, enhancement, P1)

Product:
Toolkit
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Iteration:
55.4 - May 1
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-performance])

Attachments

(2 files, 2 obsolete files)

stop using BrowserUtils.makeURI
20.33 KB, patch
jaws
: review+
Details | Diff | Splinter Review
stop using BrowserUtils.makeFileURI
1.02 KB, patch
jaws
: review+
Details | Diff | Splinter Review
I assume that when this was added the benefit was to let callers omit the last 2 parameters, but now that bug 1329182 made them optional, using this just adds cross compartment wrapper overhead (https://perfht.ml/2pXRUgd is a profile where I noticed it, although the time spent in here isn't significant).
Flags: qe-verify?
Priority: -- → P2
Attached patch remove BrowserUtils.makeURI (obsolete) — — Splinter Review
Attachment #8861068 - Flags: review?(jaws)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attached patch remove BrowserUtils.makeFileURI (obsolete) — — Splinter Review
Attachment #8861069 - Flags: review?(jaws)
Iteration: --- → 55.4 - May 1
Priority: P2 → P1
It looks like there are ~30 add-ons currently calling BrowserUtils.makeURI. Not sure if removing it was a good idea. I did it to avoid new callers from m-c without needing to make an eslint rule to ban it. Do we care about breaking 30 old style add-ons (that may already be broken for different reasons) these days?
Comment on attachment 8861068 [details] [diff] [review] remove BrowserUtils.makeURI The overhead here is negligible and not worth breaking add-ons for. This should wait until 57 when we drop support for old-style addons.
Attachment #8861068 - Flags: review?(jaws)
Comment on attachment 8861069 [details] [diff] [review] remove BrowserUtils.makeFileURI The overhead here is negligible and not worth breaking add-ons for. This should wait until 57 when we drop support for old-style addons.
Attachment #8861069 - Flags: review?(jaws)
Attachment #8861152 - Flags: review?(jaws)
Attachment #8861068 - Attachment is obsolete: true
Attachment #8861154 - Flags: review?(jaws)
Attachment #8861069 - Attachment is obsolete: true
Comment on attachment 8861152 [details] [diff] [review] stop using BrowserUtils.makeURI Review of attachment 8861152 [details] [diff] [review]: ----------------------------------------------------------------- Maybe put a note on the BrowserUtils method to say that it is deprecated?
Attachment #8861152 - Flags: review?(jaws) → review+
Comment on attachment 8861154 [details] [diff] [review] stop using BrowserUtils.makeFileURI Review of attachment 8861154 [details] [diff] [review]: ----------------------------------------------------------------- Mark this one as deprecated as well?
Attachment #8861154 - Flags: review?(jaws) → review+
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4513b54917c stop using BrowserUtils.makeURI, r=jaws. https://hg.mozilla.org/integration/mozilla-inbound/rev/3e047ce30a32 stop using BrowserUtils.makeFileURI, r=jaws.
Flags: qe-verify? → qe-verify-
https://hg.mozilla.org/mozilla-central/rev/f4513b54917c https://hg.mozilla.org/mozilla-central/rev/3e047ce30a32
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
No longer blocks: photon-performance-triage
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: