Fix various ESLint issues in services/

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Sync
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely.

At the moment, services/ doesn't inherit rules from the mozilla/recommended configuration, and so just gets a basic set.

In this patch, I'm running ESLint's autofix mechanism and then manually fixing some indentation. It is fixing rules like:

- key-spacing
- quotes (single -> double)
- no-else-return
- no-extra-semi
- comma-spacing
- object-shorthand

There's still a few errors raised after that, but I'll leave those to a mentored bug to fix.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8861112 [details]
Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic).

https://reviewboard.mozilla.org/r/133072/#review135872
Attachment #8861112 - Flags: review?(markh) → review+

Comment 3

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d4ef1185bea
Fix various ESLint issues in services/ (mostly automatic). r=markh

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5d4ef1185bea
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Updated

a year ago
Blocks: 1359540
You need to log in before you can comment on or make changes to this bug.