1359140 - Fix various ESLint issues in services/

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Banner (:standard8)]

I'm preparing to get the general ESLint rules we have in the eslint-plugin-mozilla recommended configuration spread around the tree more widely.

At the moment, services/ doesn't inherit rules from the mozilla/recommended configuration, and so just gets a basic set.

In this patch, I'm running ESLint's autofix mechanism and then manually fixing some indentation. It is fixing rules like:

- key-spacing
- quotes (single -> double)
- no-else-return
- no-extra-semi
- comma-spacing
- object-shorthand

There's still a few errors raised after that, but I'll leave those to a mentored bug to fix.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic).

This fixes various errors raised in services for the rules: key-spacing, quotes, no-else-return, no-extra-semi, comma-spacing, object-shorthand.

Review commit: https://reviewboard.mozilla.org/r/133072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133072/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8861112 [details]
Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic).

https://reviewboard.mozilla.org/r/133072/#review135872

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d4ef1185bea
Fix various ESLint issues in services/ (mostly automatic). r=markh

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d4ef1185bea