Closed Bug 1359203 Opened 3 years ago Closed 3 years ago

Create a preference to control whether legacy extensions may be enabled

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: aswan, Assigned: aswan)

References

Details

(Whiteboard: triaged)

Attachments

(3 files)

No description provided.
Priority: -- → P1
Whiteboard: triaged
First and last call for bikeshedding on the preference name.
I propose "extensions.legacy.enabled"
+1, bikeshedding period over.
Attachment #8868015 - Flags: review?(kmaglione+bmo)
Attachment #8868017 - Flags: review?(mh+mozilla)
Attachment #8868018 - Flags: review?(kmaglione+bmo)
Comment on attachment 8868017 [details]
Bug 1359203 Part 2 Add build-time constant for allowing legacy extensions

https://reviewboard.mozilla.org/r/139586/#review143388

::: browser/confvars.sh:69
(Diff revision 1)
>  
>  # Enable checking that add-ons are signed by the trusted root
>  MOZ_ADDON_SIGNING=1
>  
> +# Allow Legacy extensions unless explicitly overridden
> +MOZ_ALLOW_LEGACY_EXTENSIONS=1

Please move this to browser/moz.configure|toolkit/moz.configure. See what's done for e.g. MOZ_PLACES.
Attachment #8868017 - Flags: review?(mh+mozilla)
Comment on attachment 8868015 [details]
Bug 1359203 Part 1 Replace AddonConstants with AddonSettings

https://reviewboard.mozilla.org/r/139584/#review143806

::: toolkit/mozapps/extensions/test/browser/browser_details.js:713
(Diff revision 1)
>      });
>    });
>  });
>  
>  // These tests are only appropriate when signing can be turned off
> -if (!REQUIRE_SIGNING) {
> +if (!AppConstants.REQUIRE_SIGNING) {

These should be MOZ_REQUIRE_SIGNING

::: toolkit/mozapps/extensions/test/browser/browser_list.js:421
(Diff revision 1)
>    is(get_node(addon, "error-link").value, "More Information", "Error link text should be correct");
>    is(get_node(addon, "error-link").href, "http://example.com/addon9@tests.mozilla.org", "Error link should be correct");
>    is_element_hidden(get_node(addon, "pending"), "Pending message should be hidden");
>  
>    // These tests are only appropriate when signing can be turned off
> -  if (!REQUIRE_SIGNING) {
> +  if (!AppConstants.REQUIRE_SIGNING) {

*MOZ_REQUIRE_SIGNING
Attachment #8868015 - Flags: review?(kmaglione+bmo) → review+
Comment on attachment 8868018 [details]
Bug 1359203 Part 3 Add extensions.legacy.enabled preference

https://reviewboard.mozilla.org/r/139588/#review143812

::: toolkit/mozapps/extensions/internal/AddonSettings.jsm:43
(Diff revision 1)
> +
> +if (AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS || Cu.isInAutomation) {
> +  XPCOMUtils.defineLazyPreferenceGetter(AddonSettings, "ALLOW_LEGACY_EXTENSIONS",
> +                                        PREF_ALLOW_LEGACY, true);
> +} else {
> +  makeConstant( "ALLOW_LEGACY_EXTENSIONS", false);

Nit: Remove space after `(`
Attachment #8868018 - Flags: review?(kmaglione+bmo) → review+
Comment on attachment 8868017 [details]
Bug 1359203 Part 2 Add build-time constant for allowing legacy extensions

https://reviewboard.mozilla.org/r/139586/#review144498
Attachment #8868017 - Flags: review?(mh+mozilla) → review+
Blocks: 1360777
You need to log in before you can comment on or make changes to this bug.