Closed Bug 1359295 Opened 3 years ago Closed 3 years ago

Fix red window problem

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

patch - Call MakeCurrent() before destroying webrender renderer
707 bytes, patch
sotaro
: review+
Details | Diff | Splinter Review 
Sometimes, I saw a red window after "default browser" pop up.
Blocks: webrender
Assignee: nobody → sotaro.ikeda.g
attachment 8861274 [details] [diff] [review] addressed the problem for me.
See Also: → 1357202
Attachment #8861274 - Flags: review?(nical.bugzilla)
the patch works for me. bug 1357202 comment 9 Thank you!
Blocks: 1357202
Comment on attachment 8861274 [details] [diff] [review]
patch - Call MakeCurrent() before destroying webrender renderer

Review of attachment 8861274 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/RendererOGL.cpp
@@ +74,5 @@
>  RendererOGL::~RendererOGL()
>  {
>    MOZ_COUNT_DTOR(RendererOGL);
> +  if (!mGL->MakeCurrent()) {
> +    gfxCriticalNote << "Failed to make render context current during destroying.";

Perhaps we should return in this case and leak the renderer instead of calling into the driver after failing tomake the context current?
Attachment #8861274 - Flags: review?(nical.bugzilla) → review+
(In reply to Nicolas Silva [:nical] (away until April 18th) from comment #6)
> Perhaps we should return in this case and leak the renderer instead of
> calling into the driver after failing tomake the context current?

Yea, it seems safer and similar to CompositorOGL. I am going to update the patch.
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/708b9a300406
Call MakeCurrent() before destroying webrender renderer r=nical
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> Created attachment 8861453 [details] [diff] [review]
> patch - Call MakeCurrent() before destroying webrender renderer

works for me. All 5 STR are also gone with this 2nd patch version. Thank you :)
You need to log in before you can comment on or make changes to this bug.