1359295 - Fix red window problem

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Sometimes, I saw a red window after "default browser" pop up.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call MakeCurrent() before destroying webrender renderer

Comment 2

[Sotaro Ikeda [:sotaro]]

attachment 8861274 [details] [diff] [review] addressed the problem for me.

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=86e0ea4ccde82f1b33beb11590335c3cc2f18eb6

Comment 4

[Darkspirit]

the patch works for me. bug 1357202 comment 9 Thank you!

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=86e0ea4ccde82f1b33beb11590335c3cc2f18eb6

Comment 6

[Nicolas Silva [:nical]]

Comment on attachment 8861274 [details] [diff] [review]
patch - Call MakeCurrent() before destroying webrender renderer

Review of attachment 8861274 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/RendererOGL.cpp
@@ +74,5 @@
>  RendererOGL::~RendererOGL()
>  {
>    MOZ_COUNT_DTOR(RendererOGL);
> +  if (!mGL->MakeCurrent()) {
> +    gfxCriticalNote << "Failed to make render context current during destroying.";

Perhaps we should return in this case and leak the renderer instead of calling into the driver after failing tomake the context current?

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Nicolas Silva [:nical] (away until April 18th) from comment #6)
> Perhaps we should return in this case and leak the renderer instead of
> calling into the driver after failing tomake the context current?

Yea, it seems safer and similar to CompositorOGL. I am going to update the patch.

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call MakeCurrent() before destroying webrender renderer

Comment 9

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e0d958a74ec15d5e693a8d6944d853dd047dc0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/708b9a300406
Call MakeCurrent() before destroying webrender renderer r=nical

Comment 11

[Darkspirit]

(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> Created attachment 8861453 [details] [diff] [review]
> patch - Call MakeCurrent() before destroying webrender renderer

works for me. All 5 STR are also gone with this 2nd patch version. Thank you :)

Comment 12

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/708b9a300406