Closed
Bug 1359295
Opened 3 years ago
Closed 3 years ago
Fix red window problem
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Not set
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 1 obsolete file)
707 bytes,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
Sometimes, I saw a red window after "default browser" pop up.
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
attachment 8861274 [details] [diff] [review] addressed the problem for me.
Assignee | ||
Comment 3•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=86e0ea4ccde82f1b33beb11590335c3cc2f18eb6
Assignee | ||
Updated•3 years ago
|
Attachment #8861274 -
Flags: review?(nical.bugzilla)
Comment 4•3 years ago
|
||
the patch works for me. bug 1357202 comment 9 Thank you!
Assignee | ||
Comment 5•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=86e0ea4ccde82f1b33beb11590335c3cc2f18eb6
Comment 6•3 years ago
|
||
Comment on attachment 8861274 [details] [diff] [review] patch - Call MakeCurrent() before destroying webrender renderer Review of attachment 8861274 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/webrender_bindings/RendererOGL.cpp @@ +74,5 @@ > RendererOGL::~RendererOGL() > { > MOZ_COUNT_DTOR(RendererOGL); > + if (!mGL->MakeCurrent()) { > + gfxCriticalNote << "Failed to make render context current during destroying."; Perhaps we should return in this case and leak the renderer instead of calling into the driver after failing tomake the context current?
Attachment #8861274 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 7•3 years ago
|
||
(In reply to Nicolas Silva [:nical] (away until April 18th) from comment #6) > Perhaps we should return in this case and leak the renderer instead of > calling into the driver after failing tomake the context current? Yea, it seems safer and similar to CompositorOGL. I am going to update the patch.
Assignee | ||
Comment 8•3 years ago
|
||
Attachment #8861274 -
Attachment is obsolete: true
Attachment #8861453 -
Flags: review+
Assignee | ||
Comment 9•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e0d958a74ec15d5e693a8d6944d853dd047dc0
Comment 10•3 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/708b9a300406 Call MakeCurrent() before destroying webrender renderer r=nical
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Comment 11•3 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #8) > Created attachment 8861453 [details] [diff] [review] > patch - Call MakeCurrent() before destroying webrender renderer works for me. All 5 STR are also gone with this 2nd patch version. Thank you :)
https://hg.mozilla.org/mozilla-central/rev/708b9a300406
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•