1359309 - Give mozilla::TaskQueue a name

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

It will help debug the crash in bug 1347056 by dumping the name of the AbstractThread when dispatch fails.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1359309. P1 - give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures.

Review commit: https://reviewboard.mozilla.org/r/133784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133784/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1359309. P2 - dump the name of the TaskQueue when Dispatch() fails.

Review commit: https://reviewboard.mozilla.org/r/133786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133786/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8861781 [details]
Bug 1359309. P1 -  give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures.

https://reviewboard.mozilla.org/r/133784/#review136784

::: xpcom/threads/TaskQueue.cpp:80
(Diff revision 1)
>    MOZ_COUNT_CTOR(TaskQueue);
>  }
>  
> +TaskQueue::TaskQueue(already_AddRefed<nsIEventTarget> aTarget,
> +                     bool aSupportsTailDispatch)
> +  : TaskQueue(Move(aTarget), "UnknownTaskQueue", aSupportsTailDispatch)

Unnamed instead maybe? since it's not unknown per say

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8861782 [details]
Bug 1359309. P2 - dump the name of the TaskQueue when Dispatch() fails.

https://reviewboard.mozilla.org/r/133786/#review137218

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8861781 [details]
Bug 1359309. P1 -  give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133784/diff/1-2/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8861782 [details]
Bug 1359309. P2 - dump the name of the TaskQueue when Dispatch() fails.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133786/diff/1-2/

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/aa3861fcf0ad
P1 -  give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures. r=jya
https://hg.mozilla.org/mozilla-central/rev/f4cd33b24029
P2 - dump the name of the TaskQueue when Dispatch() fails. r=jya

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aa3861fcf0ad
https://hg.mozilla.org/mozilla-central/rev/f4cd33b24029