Closed Bug 1359309 Opened 3 years ago Closed 3 years ago

Give mozilla::TaskQueue a name

Categories

(Core :: XPCOM, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It will help debug the crash in bug 1347056 by dumping the name of the AbstractThread when dispatch fails.
Assignee: nobody → jwwang
Blocks: 1347056
Priority: -- → P3
Summary: Give AbstractThread a name → Give mozilla::TaskQueue a name
Depends on: 1358442
Attachment #8861781 - Flags: review?(jyavenard)
Attachment #8861782 - Flags: review?(jyavenard)
Comment on attachment 8861781 [details]
Bug 1359309. P1 -  give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures.

https://reviewboard.mozilla.org/r/133784/#review136784

::: xpcom/threads/TaskQueue.cpp:80
(Diff revision 1)
>    MOZ_COUNT_CTOR(TaskQueue);
>  }
>  
> +TaskQueue::TaskQueue(already_AddRefed<nsIEventTarget> aTarget,
> +                     bool aSupportsTailDispatch)
> +  : TaskQueue(Move(aTarget), "UnknownTaskQueue", aSupportsTailDispatch)

Unnamed instead maybe? since it's not unknown per say
Attachment #8861781 - Flags: review?(jyavenard) → review+
Comment on attachment 8861782 [details]
Bug 1359309. P2 - dump the name of the TaskQueue when Dispatch() fails.

https://reviewboard.mozilla.org/r/133786/#review137218
Attachment #8861782 - Flags: review?(jyavenard) → review+
Thanks!
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/aa3861fcf0ad
P1 -  give mozilla::TaskQueue a name which will be useful in debugging Dispatch() failures. r=jya
https://hg.mozilla.org/mozilla-central/rev/f4cd33b24029
P2 - dump the name of the TaskQueue when Dispatch() fails. r=jya
https://hg.mozilla.org/mozilla-central/rev/aa3861fcf0ad
https://hg.mozilla.org/mozilla-central/rev/f4cd33b24029
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.