1359339 - The icons of the the default top sites are oversized when starting Fennec in landscape (iPhone 6/7 Plus)

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect, P1)

Description

[Catalin Suciu [:csuciu]]

master f9f4cf1ba
iPhone 6 Plus (10.3)

1. Place the device in landscape.
2. Install Firefox via Xcode. 
3. "Start Browsing" in First Run Tour.
4. Check the top sites in landscape.

Result: http://imgur.com/W2NINTD

5. Switch to portrait.

Result: http://imgur.com/a/Reier

Comment 1

[Farhan Patel [:farhan]]

I cant seem to reproduce this on master ec47141
is this still happening, I tried this on both a iphone 6 and 6plus simulator.

Comment 2

[Catalin Suciu [:csuciu]]

'WORKSFORME' on master d9c3ccb68

Comment 3

[Catalin Suciu [:csuciu]]

I'm able to reproduce this issue on master bcd93f1319/iPhone 6 Plus (10.3.2) using the STR's from the description.

Comment 4

[Aaron Train [:aaronmt]]

Reproducible on my iPhone 7+

Comment 5

[Farhan Patel [:farhan]]

Attachment: Pull Request

Catalin can you try this PR on your device if you get the chance. Im sure this will fix it but I cant replicate this in the simulator.

Comment 6

[Catalin Suciu [:csuciu]]

Attachment: Screen Shot 2017-05-25 at 15.04.22.png

I've tried the patch and I'm still able to reproduce. Also I was able to reproduce in the simulator (see the attached screenshot).

Comment 7

[Farhan Patel [:farhan]]

Do you have some more steps I can use for the Simulator. I cant reproduce this on the same iphone 6 plus simulator.

Comment 8

[Farhan Patel [:farhan]]

Simon and I were not able to replicate this on master 24ca2db

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Oops I added my patch to the wrong bug.