Closed
Bug 1359360
Opened 7 years ago
Closed 7 years ago
Return draw result for background image layer
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
(Keywords: correctness)
Attachments
(1 file)
|
20.99 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Currently we don't return draw result when we generating webrender commands in nsDisplayBackgroundImage. It will cause test failures since we may snapshot before the image is ready.
|
Assignee | |
Comment 1•7 years ago
|
||
We should update the draw result to nsDisplayBackgroundGeometry so that we won't get wrong snapshot.
Attachment #8861355 -
Flags: review?(matt.woodrow)
|
||
Updated•7 years ago
|
Attachment #8861355 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc0d4f33161ee33c815546f216e8aaef3dc84c79
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/cb1d0757e1c0 Handle draw result for webrender background image layer. r=mattwoodrow
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cb1d0757e1c0
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•