1359369 - [Static Analysis][Dereference before null check] In function NS_GetIsDocumentChannel

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that |aIsDocument| is dereferenced before being null checked, thus leading to a possible null pointer dereference.

>>NS_GetIsDocumentChannel(nsIChannel * aChannel, bool *aIsDocument)
>>{
>>  // Check if this channel is going to be used to create a document. If it has
>>  // LOAD_DOCUMENT_URI set it is trivially creating a document. If
>>  // LOAD_HTML_OBJECT_DATA is set it may or may not be used to create a
>>  // document, depending on its MIME type.
>>
>>  if (!aChannel || !aIsDocument) {
>>      return NS_ERROR_NULL_POINTER;
>>  }
>>  nsLoadFlags loadFlags;

Comment 1

[Andi [:andi]]

Attachment: Bug 1359369 - prevent null pointer dereference in NS_GetIsDocumentChannel.

Review commit: https://reviewboard.mozilla.org/r/133352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133352/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8861366 [details]
Bug 1359369 - prevent null pointer dereference in NS_GetIsDocumentChannel.

https://reviewboard.mozilla.org/r/133352/#review136204

Nice one. Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9517822fdfa7
prevent null pointer dereference in NS_GetIsDocumentChannel. r=valentin

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9517822fdfa7