1359413 - EARLY_BETA_OR_EARLIER safeguard doesn't work anymore

Status: RESOLVED INVALID

(Firefox Build System :: General, enhancement)

Description

[[e-mail] (:bhearsum)]

While reading up on EARLY_BETA_OR_EARLIER I came across this comment in mozconfigs like https://dxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/linux32/release:
"# safeguard against someone forgetting to re-set EARLY_BETA_OR_EARLIER in
# defines.sh during the beta cycle"

However, EARLY_BETA_OR_EARLIER is set plainly in defines.sh these days, and has no such protection: https://dxr.mozilla.org/mozilla-central/source/build/defines.sh#3

It looks like this used to be a thing, because I found the safeguarding in old-configure: https://dxr.mozilla.org/mozilla-central/source/old-configure#10930

Comment 1

[Gregory Szorc [:gps]]

Is this important?

(What I'm really asking is whether we should remove the check or fix it.)

Comment 2

[Chris Peterson [:cpeterson]]

Closing because we'll be removing EARLY_BETA_OR_EARLIER in bug 2051729.