Simplify/optimize SharedContext::isFunctionBox

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Posted patch PatchSplinter Review
Currently we have a virtual call to get the ObjectBox and then check if it's a FunctionBox, but we can just check the Kind enum.

I noticed the virtual call in a profile and this patch also simplifies the code a bit.
Attachment #8861431 - Flags: review?(shu)

Comment 1

2 years ago
Comment on attachment 8861431 [details] [diff] [review]
Patch

Review of attachment 8861431 [details] [diff] [review]:
-----------------------------------------------------------------

Oh cool, thanks for the patch.
Attachment #8861431 - Flags: review?(shu) → review+

Comment 2

2 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28e4528663c4
Simplify/optimize SharedContext::isFunctionBox by removing an unnecessary virtual call. r=shu
(Assignee)

Comment 3

2 years ago
This improved Octane-CodeLoad by 2.7% on the Mac x64 slave.

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28e4528663c4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.