Closed
Bug 1359421
Opened 8 years ago
Closed 8 years ago
Simplify/optimize SharedContext::isFunctionBox
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
3.86 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Currently we have a virtual call to get the ObjectBox and then check if it's a FunctionBox, but we can just check the Kind enum.
I noticed the virtual call in a profile and this patch also simplifies the code a bit.
Attachment #8861431 -
Flags: review?(shu)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8861431 [details] [diff] [review]
Patch
Review of attachment 8861431 [details] [diff] [review]:
-----------------------------------------------------------------
Oh cool, thanks for the patch.
Attachment #8861431 -
Flags: review?(shu) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28e4528663c4
Simplify/optimize SharedContext::isFunctionBox by removing an unnecessary virtual call. r=shu
|
Assignee | |
Comment 3•8 years ago
|
||
This improved Octane-CodeLoad by 2.7% on the Mac x64 slave.
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•