Closed Bug 1359462 Opened 4 years ago Closed 4 years ago
_dp _new _clip _region tries to make a slice using a nullptr
59 bytes, text/x-review-board-request
See bug 1357734 comment 13 for backstory. Any call to DisplayListBuilder::BuildClipRegion(rect, mask) will pass nullptr as the complex clip list pointer down to rust code, which passes that nullptr directly into slice::from_raw_parts , which is not allowed per the from_raw_parts documentation. This is potentially the cause of bug 1357734, although I'm not sure about that yet.  http://searchfox.org/mozilla-central/rev/baf47b352e873d4516d7656186d6d7c7447d3873/gfx/webrender_bindings/src/bindings.rs#1119
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8d00a9b28d34952d9df5a45f51ccc195d812ef7 ^ I wrote the patches based on master originally and pushed to try. I had to rebase onto graphics which was slightly nontrivial. I think it makes more sense to land on graphics.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ec4085ba33f0dff556c7d99d14f6f962ab6f850 ^ push to try after rebase to graphics.
Whoops, screwed that up. New patches coming.
4 years ago
Comment on attachment 8861531 [details] Bug 1359462 - Ensure we don't pass a nullptr to slice::from_raw_parts. https://reviewboard.mozilla.org/r/133506/#review136404 Thanks!
Attachment #8861531 - Flags: review?(rhunt) → review+
Pushed by email@example.com: https://hg.mozilla.org/projects/graphics/rev/5fe20b166827 Ensure we don't pass a nullptr to slice::from_raw_parts. r=rhunt
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.