Closed Bug 1359501 Opened 4 years ago Closed 4 years ago

Look for artifact builds from beta repo

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 fixed, firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file)

Bug 1359501 - Accept artifact builds from beta.
59 bytes, text/x-review-board-request
chmanchester
: review+
gchang
: approval-mozilla-beta+
Details 
It appears we're producing artifact builds from beta, so let's allow them to be used.
Comment on attachment 8861528 [details]
Bug 1359501 - Accept artifact builds from beta.

https://reviewboard.mozilla.org/r/133490/#review136374

Bear in mind MOZ_ARTIFACT_REVISION can be set if you want to pull a specific revision as a one off.

This stops us from finding changes on aurora. Is it going away soon enough that this isn't an issue?
Attachment #8861528 - Flags: review?(cmanchester)
Comment on attachment 8861528 [details]
Bug 1359501 - Accept artifact builds from beta.

https://reviewboard.mozilla.org/r/133490/#review136374

Well, we aren't uplifting to aurora anymore, so I've already written it off in my mind... :) But, maybe it's a little too early.  I'll add beta to the list instead of replacing.
Comment on attachment 8861528 [details]
Bug 1359501 - Accept artifact builds from beta.

https://reviewboard.mozilla.org/r/133490/#review136990

Ah, if we're no longer uplifting to Aurora I'm fine with leaving that off. Either way, r+
Attachment #8861528 - Flags: review?(cmanchester) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9393b01de6fc
Accept artifact builds from beta. r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/9393b01de6fc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8861528 [details]
Bug 1359501 - Accept artifact builds from beta.

Approval Request Comment
[Feature/Bug causing the regression]: No regression, this makes beta artifact builds easily accessible to developers.
[User impact if declined]: If declined, it will be harder to use beta artifact builds.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects local dev builds
[String changes made/needed]: None
Attachment #8861528 - Flags: approval-mozilla-beta?
Comment on attachment 8861528 [details]
Bug 1359501 - Accept artifact builds from beta.

This makes beta artifact builds easily accessible to developers. Beta54+. Should be in 54 beta 5.
Attachment #8861528 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.